Fixes invalid redirection for /admin when browser is not set to English #267
+14
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o that we have access to the url resolver. Then check if the requested path belongs to i18n_patterns.
saevarom
changed the title
|
Great! Thank you! Is it okay if I write some tests for this? |
Sure |
thibaudcolas
approved these changes
May 10, 2023
|
I see the tests are still in progress in #277, but the fix itself seems worthwhile to include already, so I’ll merge now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262.
Move the homepage lookup after response handling so that we have access to the url resolver. Then check if the requested path belongs to i18n_patterns so that we are not handling e.g.
/adminas a localized URL.To test this you will need to:
/adminworks properly/works properly and redirects to `/en-latest``/adminworks properly/redirects to/de-latest/and shows a 404 page with the English menu