Support Setting A Model's Search Field Through A Setting#190
Open
dchukhin wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Case:
The use case for this feature is a project using Django's default user model, with a
Pagethat has a relation to the user model. Since Django's default user model does not have atitlefield, it's not possible to usewagtail-autocompleteon the relation. One option would be to define a custom user model and atitlefield, but doing so mid-project a difficult task. Instead, it would be great to be able to point the search to a different field on the model without having to edit the model.Changes
This pull request:
views.render_page()function to check (only if the page doesn't have anautocomplete_labelattribute) for aWAGTAILAUTOCOMPLETE_CUSTOM_SEARCH_FIELDsetting, and (if the setting is defined) to use the value of that setting.views.filter_queryset()function to check (only if the page doesn't have anautocomplete_search_fieldattribute) for aWAGTAILAUTOCOMPLETE_CUSTOM_FILTER_FIELDSsetting, and (if the setting is defined) to use the value of that setting.As a result, it is now possible to define which field(s) to use in the search without having to edit the model.