Conversation
Codecov Report
@@ Coverage Diff @@
## main #136 +/- ##
==========================================
+ Coverage 64.97% 65.53% +0.55%
==========================================
Files 32 32
Lines 1262 1262
Branches 227 227
==========================================
+ Hits 820 827 +7
+ Misses 400 393 -7
Partials 42 42
Continue to review full report at Codecov.
|
c55c08b to
37fce62
Compare
|
@Morsey187 Did you see this PR :) I'm not entirely sure this is really the way to go and maybe it's been over thought and do we really need the level of exceptions here as we don't actually do much with the messages as yet. As is stands the package seems to be working well without this and it's probably a better idea to alter it when we get around to the extra logging where the extra messages would be more useful. I'd appreciate your thoughts on it. Thanks |
Change the order of requests exceptions.
Changed following earlier MR comments: #134