feat: incentivization PoC: client-side reputation system basics #3293
+103
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-tikhomirov
changed the title
|
You can find the image built from this PR at Built from 425506b |
s-tikhomirov
force-pushed
the
feat/incentivization-poc-reputation
branch
from
fce0795 to
2cd7d30
Compare
s-tikhomirov
changed the title
gabrielmer
approved these changes
Feb 20, 2025
jm-clius
approved these changes
Feb 20, 2025
s-tikhomirov
force-pushed
the
feat/incentivization-poc-reputation
branch
from
2cd7d30 to
ecf94f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements parts of a simple client-side reputation system that don't require modifications in the Lightpush protocol.
This is a countinuaton of #3166 and #3264 with associated deliverable waku-org/pm#245.
The goal of this PR is to merge parts of the reputation system that don't require integration into any real protocol (Lightpush or otherwise). This functionality aims to encompass common functions that all reputation-enhanced protocols will use (Lightpush will be the first but probably not the only protocol to do so).
In a reputation-enhanced protocol, clients remember the results of their interactions with servers and update the servers' reputation scores accordingly. If a server sends a bad request (for some definition of response quality implemented in the respective response evaluation functionality), that server's reputation is set to "bad".
Note that reputation indicators have no relation to gossipsub peer scores. It is possible that reputation indicators from client-server protocols will play a role in peer scoring as an application-specific component (cf.
p_5in the peer score formula). This idea is left for future work.Changes
List of detailed changes
isSuccessfield istrue)The next steps will imply integrating the eligibility- and reputation-related functionality in the Lightpush protocol (behind a feature flag) that involve amending the relevant protobuf structures and peer selection mechanism. In particular, a client will avoid selecting bad servers for all its future requests. Also, response quality evaluation will involve making a Store request to ensure a given message has indeed been published.