chore: more efficient metrics usage #3298
Draft
+88
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bound the metrics-label-values in arbitrary queries. * The metrics-label-values for prepared statements are kept as they already represent a fixed set.
|
You can find the image built from this PR at Built from 6787618 |
jakubgs
approved these changes
Feb 18, 2025
Comment on lines
+240
to
+245
| if query.contains("contentTopic IN"): | ||
| return ContentTopicQuery | ||
| elif query.contains("SELECT version()"): | ||
| return SelectVersionQuery | ||
| elif query.contains("WITH min_timestamp"): | ||
| return MessagesLookupQuery |
There was a problem hiding this comment.
Don't you have like a key-value map in Nim?
There was a problem hiding this comment.
Don't you have like a key-value map in Nim?
Yes. In this case, the query variable has longer content and we are just filtering by a substring.
There was a problem hiding this comment.
Yeah, but can't you just use keys as prefixes and iterate over them?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
they already represent a fixed set.
Issue
closes #3282