Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

puppet: remove okhttp dependency #160

Merged
merged 2 commits into from
Jul 19, 2024
Merged

puppet: remove okhttp dependency #160

merged 2 commits into from
Jul 19, 2024

Conversation

benbroadaway
Copy link
Collaborator

@benbroadaway benbroadaway commented Jun 24, 2024 •
edited
Loading

  • remove dependency on okhttp 2.X in favor of native HttpClient
  • use custom self-signed cert in wiremock tests for verification of task's self-signed cert handling
    • Native http library forces hostname verification by default, so PuppetHostnameVerifier is not longer necessary
  • validate self-signed cert expiration (notAfter)
    • add option to disable this validation

@benbroadaway benbroadaway requested review from ibodrov and a team June 24, 2024 16:01
ibodrov
ibodrov previously approved these changes Jun 24, 2024
View reviewed changes
Copy link
Collaborator

@ibodrov ibodrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise LGTM

@mtkunkel mtkunkel merged commit 00e7af7 into master Jul 19, 2024
1 check passed
@mtkunkel mtkunkel deleted the puppet-remove-okhttp branch July 19, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibodrov ibodrov ibodrov approved these changes

@mtkunkel mtkunkel mtkunkel approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benbroadaway @ibodrov @mtkunkel