Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

msteams: remove apache httpclient dependency, add unit and integration tests #163

Merged
merged 1 commit into from
Jul 25, 2024
Merged

msteams: remove apache httpclient dependency, add unit and integration tests #163

merged 1 commit into from
Jul 25, 2024

Conversation

benbroadaway
Copy link
Collaborator

  • Replace apache httpclient usage with native HttpClient
  • Add unit tests
  • Add integration tests. They're disabled by default, requires external config for secrets

@benbroadaway benbroadaway requested review from ibodrov and a team June 26, 2024 14:30
@mtkunkel mtkunkel merged commit 046dcc9 into master Jul 25, 2024
1 check passed
@mtkunkel mtkunkel deleted the msteams-remove-apache-http branch July 25, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtkunkel mtkunkel mtkunkel approved these changes

@ibodrov ibodrov Awaiting requested review from ibodrov

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@benbroadaway @mtkunkel