Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug: Nothing happens to the original object after manipulation #444

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

delapecci
Copy link

Fix bug: Nothing happens to the original dayjs object after manipulations, should assign to the new cloned one

@wanasit
Copy link
Owner

wanasit commented Mar 28, 2022

Thank you @delapecci.
I am curious why didn't those fail the tests. Could you also add test cases to confirm the issue got addressed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants