Open
Conversation
- Don't override the default scope in login!. - Pass through all options to set_user in login!. - Don't define classes in rspec before blocks. Use a support file. - Test parameters and return values of the controller mixins. - Fix a typo in the rails_warden spec. - Add .ruby-gemset to gitignore. - Add Rails 7.0 and Ruby 3.1 to the tested versions. - Frozen string literals everywhere.
Author
|
I verified that the tests passed locally using https://github.com/nektos/act to run the actions. |
Author
|
@jsmestad can you take a look? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
login!.login!.beforeblocks. Use a support file.