chore: add support for Gatsby v4 #67
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithc
force-pushed
the
feature/support-gatsby-v4
branch
from
f460c93 to
62dd35e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apologies for duplicating the majority of functionality of this PR (#66); I only realized after the fact that somebody else had already made an effort to address this.
I'm still opening a PR with this particular implementation because I think there is a key distinction between the two PRs that merits review:
pathparameter to theloadershould be preserved in theoriginalLoadPageSyncandoriginalLoadPagefunctions (based on the behavior seen here: https://github.com/gatsbyjs/gatsby/pull/33209/files#diff-177ac96ca321818b0022cdaa9fda344808eed92150a112f28ff205cda29b8049R30)I think that this supports the spirit of the change introduced in that PR (gatsbyjs/gatsby#33209).