Reformat with biome 2.5.6 and ignore the lru advisory - #2435
Merged
Conversation
Two CI checks have been failing on every pull request against main, and neither is caused by the branches they fail on. biome was bumped from 2.5.5 to 2.5.6 in warp-tech#2313 and the tree was not reformatted, so `biome ci` has reported four errors in three files ever since — formatting in AuthPolicyEditor and ConnectionInstructions, import order in CollapsibleBlock. `biome check --write` is the whole change; no behaviour is touched. cargo-deny fails on RUSTSEC-2026-0253, an unsound `LruCache::pop` in lru 0.16.4. That version is pinned by aws-sdk-s3 1.137.0 and cannot be raised from here: the fix landed in 0.18.2, which is a breaking change for a 0.x crate. The other lru in the tree, 0.18.2 via ratatui-core, is unaffected. Added to the existing ignore list beside RUSTSEC-2026-0104, which is there for the same reason and the same SDK. Verified with the versions the workflows pin, biome 2.5.6 and cargo-deny 0.18.9: `Checked 154 files. No fixes applied.` and `advisories ok, bans ok, licenses ok, sources ok`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI checks fail on every recently-run pull request against
main, and neither is caused by the branch they fail on. Both are one-line-scale fixes.Description
biome — three files drifted, and nothing on
mainchecks them.github/workflows/biome.ymlrunson: [pull_request]only, somainitself is never formatted-checked. Three files were changed by merges that did not run the formatter:warpgate-web/src/admin/config/users/AuthPolicyEditor.sveltewarpgate-web/src/common/CollapsibleBlock.sveltewarpgate-web/src/common/ConnectionInstructions.svelteEvery pull request opened or updated since then inherits the four errors: formatting in
AuthPolicyEditorandConnectionInstructions, import order inCollapsibleBlock.biome check --writeis the whole change; no behaviour istouched.
cargo-deny — an advisory in a transitive dependency we cannot raise
RUSTSEC-2026-0253, an unsoundLruCache::popinlru0.16.4. That version is pinned byaws-sdk-s31.137.0 and cannot be raised from here: the fix landed inlru0.18.2, which is a breaking change for a0.xcrate. The otherlruinthe tree — 0.18.2, via
ratatui-core— is unaffected.Added to the existing ignore list beside
RUSTSEC-2026-0104, which is there for the same reason and the same SDK. Happy to drop this hunk if you would rather wait for anaws-sdk-s3bump.Pull requests currently red for these two reasons
#2432, #2429, #2427, #2413, #2397 — every open PR whose checks have run since 12 August. (#2396 and #2387 are green only because their last run predates the drift.)
Verified with the versions the workflows pin
biome2.5.6, per.github/workflows/biome.yml:cargo-deny0.18.9, per.github/workflows/cargo-deny.yml:Worth using the pinned versions rather than whatever is installed locally:
cargo-deny0.20.2 passes onmainwithout this change, because it treatsthe
unsoundclass differently, so confirming against it would prove nothing.AI Usage
Choose the level of AI involvement for this PR.
This is not to block AI contributions but rather to speed up PR review (saves time on trying to deduce the logic behind AI hallucinations).