skip registering secure_storage for remote daemon#12479
Merged
Conversation
Contributor
|
I'm starting a first review of this pull request. You can view the conversation on Warp. I completed the review and no human review was requested for this pull request. Comment Powered by Oz |
Contributor
There was a problem hiding this comment.
Overview
This PR skips platform secure-storage registration for RemoteServerDaemon launch mode and registers an intentionally unavailable provider that avoids persistent secret access while allowing daemon auth to arrive through the remote-server handshake.
Concerns
- No blocking correctness, security, or spec-alignment concerns found in the changed diff.
Verdict
Found: 0 critical, 0 important, 0 suggestions
Approve
Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).
Powered by Oz
kevinyang372
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Here's the original issue report: #12449
The issue is because of our dependency on secure storage, which has platform specific implementations so on Linux it uses
SecretServicewhich results in the reported lock issue. We technically don't need it for the remote daemon case because we handle auth in thehandshake, we are just incidentally using it right now during daemon setup so I'm skipping it for the remote daemon case.Linked Issue
#12449
ready-to-specorready-to-implement.Testing
./script/runScreenshots / Videos
Agent Mode