Skip to content

skip registering secure_storage for remote daemon#12479

Merged
moirahuang merged 1 commit into
masterfrom
moira/secret-service
Jun 11, 2026
Merged

skip registering secure_storage for remote daemon#12479
moirahuang merged 1 commit into
masterfrom
moira/secret-service

Conversation

@moirahuang

@moirahuang moirahuang commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Description

Here's the original issue report: #12449

The issue is because of our dependency on secure storage, which has platform specific implementations so on Linux it uses SecretService which results in the reported lock issue. We technically don't need it for the remote daemon case because we handle auth in thehandshake, we are just incidentally using it right now during daemon setup so I'm skipping it for the remote daemon case.

Linked Issue

#12449

  • The linked issue is labeled ready-to-spec or ready-to-implement.
  • Where appropriate, screenshots or a short video of the implementation are included below (especially for user-visible or UI changes).

Testing

Screenshot 2026-06-10 at 3.54.16 PM.png

  • I have manually tested my changes locally with ./script/run

Screenshots / Videos

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

@cla-bot cla-bot Bot added the cla-signed label Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@moirahuang moirahuang requested a review from kevinyang372 June 10, 2026 22:56
@moirahuang moirahuang marked this pull request as ready for review June 10, 2026 22:56
@oz-for-oss

oz-for-oss Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

@moirahuang

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I completed the review and no human review was requested for this pull request.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@oz-for-oss oz-for-oss Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

This PR skips platform secure-storage registration for RemoteServerDaemon launch mode and registers an intentionally unavailable provider that avoids persistent secret access while allowing daemon auth to arrive through the remote-server handshake.

Concerns

  • No blocking correctness, security, or spec-alignment concerns found in the changed diff.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@moirahuang moirahuang merged commit a18da95 into master Jun 11, 2026
54 checks passed
@moirahuang moirahuang deleted the moira/secret-service branch June 11, 2026 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants