Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move helper code to separate files #91

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: Move helper code to separate files #91

wants to merge 1 commit into from
+1,033 −996

Conversation

theduke
Copy link
Collaborator

@theduke theduke commented Jan 28, 2025

The test.ts file got quite messy, being 2k+ lines long...

@theduke
refactor: Move helper code to separate files
be88810 
The test.ts file got quite messy, being 2k+ lines long...
baalimago
baalimago approved these changes Jan 29, 2025
View reviewed changes
Copy link
Collaborator

@baalimago baalimago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I have another integration test upgrade incoming as well. I think we should merge this first, and I'll submit a PR once mine is ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baalimago baalimago baalimago approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theduke @baalimago