-
Notifications
You must be signed in to change notification settings - Fork 922
feat(llvm): Pass global #0 and memory #0 as parameters between guest functions #5503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88af7a5 to
197c240
Compare
…n of LLVM types with g0m0 enabled
…, use current opts as part of the ID
|
📝 Documentation updates detected! A separate PR for documentation updates has been made here: wasmerio/docs.wasmer.io#126 |
syrusakbary
approved these changes
Apr 22, 2025
…mpilerOptimizations`
feat: Add `SuggestedCompilerOptimization` type(s) to automatically infer when to enable g0m0 optimization
feat: Add support for `perfmap`-based profiler data generation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(closes #5493 #5494)
This PR adds the
--enable-pass-params-optflag to the CLI and theenable_pass_params_opt()function to theLLVMcompiler.This optimization is turned off by default. It assumes that the Wasm module to compile has both a global (
g0) and a memory (m0) defined in it. The objective of the optimization is that of passing the value ofg0and a pointer to the base ofm0as parameters between guest functions, in order to reduce the overhead of loading these values through (multiple) pointers (i.e.,loads in the generated code).Pitfalls
In some cases this optimization works very well, speeding up the execution times of modules such as
php:vs
In some other cases, passing
g0andm0as parameters can be actually an hindrance, making the execution slower. In my opinion, this is due to the fact thatg0andm0are passed as second and third parameters to generated guest functions, which might cause other parameters to be spilled onto the stack. Thus, depending on which ofg0,m0or the other spilled parameters is used more, this optimization might actually slow things down.