Dry up subscription status #382
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sodic
commented
Feb 21, 2025
Comment on lines
92
to
104
| const selectedValue = e.target.value == '' ? null : e.target.value; | ||
|
|
||
| if (selectedValue === 'clear-all') { | ||
| setSubcriptionStatusFilter([]); | ||
| } else { | ||
| setSubcriptionStatusFilter((prevValue) => { | ||
| if (prevValue.includes(selectedValue as SubscriptionStatus)) { | ||
| return prevValue.filter((val) => val !== selectedValue); | ||
| } else { | ||
| return [...prevValue, selectedValue as SubscriptionStatus]; | ||
| } | ||
| }); | ||
| } |
There was a problem hiding this comment.
Not ideal but best we can do for the time being.
| // becomes 'unpaid' and finally 'expired' (i.e. 'deleted'). | ||
| // NOTE: ability to pause or trial a subscription is something that has to be additionally configured in the lemon squeezy dashboard. | ||
| // becomes 'unpaid' and finally 'expired' (i.e. 'deleted'). | ||
| // NOTE: ability to pause or trial a subscription is something that has to be additionally configured in the lemon squeezy dashboard. | ||
| // If you do enable these features, make sure to handle these statuses here. | ||
| if (status === 'past_due' || status === 'active') { |
There was a problem hiding this comment.
I didn't change these because they're lemonSqueezy status strings, not ours (although lexically the same at the moment).
Same goes for Stripe.
3 tasks
infomiho
reviewed
Feb 21, 2025
| @@ -106,7 +109,7 @@ async function handleSubscriptionCreated(data: Subscription, userId: string, pri | |||
| lemonSqueezyId, | |||
| userId, | |||
| subscriptionPlan: planId, | |||
| subscriptionStatus: status, | |||
| subscriptionStatus: status as SubscriptionStatus, | |||
There was a problem hiding this comment.
I think some of these assertions won't be necessary once we merge #377
infomiho
reviewed
Feb 21, 2025
| @@ -1,6 +1,11 @@ | |||
| import { requireNodeEnvVar } from '../server/utils'; | |||
|
|
|||
| export type SubscriptionStatus = 'past_due' | 'cancel_at_period_end' | 'active' | 'deleted'; | |||
| export enum SubscriptionStatus { | |||
There was a problem hiding this comment.
We attacked the same thing: https://github.com/wasp-lang/open-saas/pull/379/files#diff-4840b1aee17262f7d02b6e108dc85da00de2b5a91f5e92eb83b862aed83a6fadR4 with different tools :D
There was a problem hiding this comment.
I used the enum for the definition, and referenced the enum in Zod during validation using z.nativeEnum.
infomiho
approved these changes
Feb 21, 2025
vincanger
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subscription statuses were repeated all over the app.
They're now defined in a single place and imported where necessary.