Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Do not add default plugins to Vite #2451

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Palid
Copy link

@Palid Palid commented Jan 12, 2025

Description

Due to vite's plugin resolution and lack of deduplication/overriding, we cannot really have any defaults for sets of plugins in the Vite config.

This commit removes the default plugins from the Vite config from the CLI-generated React app, and instead adds them to the generated app template.

Fixes #2437
Refs discord discussion: https://discord.com/channels/686873244791210014/812664118887841813/threads/1325994905822302343

Select what type of change this PR introduces:

  1. Just code/docs improvement (no functional change).
  2. Bug fix (non-breaking change which fixes an issue).
  3. New feature (non-breaking change which adds functionality).
  4. Breaking change (fix or feature that would cause existing functionality to not work as expected).

Update Waspc ChangeLog and version if needed

If you did a bug fix, new feature, or breaking change, that affects waspc, make sure you satisfy the following:

  1. I updated ChangeLog.md with description of the change this PR introduces.
  2. I bumped waspc version in waspc.cabal to reflect changes I introduced, with regards to the version of the latest wasp release, if the bump was needed.

Due to vite's plugin resolution and lack of deduplication/overriding,
we cannot really have any defaults for sets of plugins in the Vite config.

This commit removes the default plugins from the Vite config from the
CLI-generated React app, and instead adds them to the generated app
template.
@Palid
Copy link
Author

Palid commented Jan 12, 2025

I didn't bump waspc version in wasp.cabal, as due to it being a breaking change I want to make sure it gets released properly.

If there's any additional documentation I need to prepare in addition to this, please let me know, as I'd love to have this change as quickly as possible as it literally blocks me from trying out wasp for my usecase. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure out support for overriding default react plugin in Vite
1 participant