wave: run graphql asynchronously on flask server#1
Merged
lukaspiatkowski merged 1 commit intowave-releasefrom Sep 14, 2023
Merged
wave: run graphql asynchronously on flask server#1lukaspiatkowski merged 1 commit intowave-releasefrom
lukaspiatkowski merged 1 commit intowave-releasefrom
Conversation
In GraphQLView.dispatch_request pass run_sync=False to run_http_query and, if necessary, run the result on async loop. There is an open PR upstream to handle async natively: graphql-python#110
Member
Author
|
This is basically to replace the hacky override we have right now in money-srv with a forked graphql-server, see the hacky code here: https://github.com/wavemm/monorepo/blob/cdf17e944881d6c3cb7110b13e29e741c13af1e9/money-srv/src/interface/graphql/execution.py#L614-L651 |
|
Hmm, yeah, the loop part is interesting—I'm curious too if it's necessary for correctness. /approve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
GraphQLView.dispatch_requestpassrun_sync=Falsetorun_http_queryand, if necessary, run the result on async loop.There is an open PR upstream to handle async natively: graphql-python#110