Skip to content

Add wvmos sigmos#42

Merged
ftshijt merged 9 commits into
wavlab-speech:mainfrom
nezihtopaloglu:add_wvmos_sigmos
Jul 1, 2025
Merged

Add wvmos sigmos#42
ftshijt merged 9 commits into
wavlab-speech:mainfrom
nezihtopaloglu:add_wvmos_sigmos

Conversation

@nezihtopaloglu
Copy link
Copy Markdown
Contributor

This update adds two metrics, WVMOS and SIGMOS.

WVMOS: https://github.com/AndreevP/wvmos

SIGMOS: https://github.com/microsoft/SIG-Challenge/tree/main/ICASSP2024/sigmos

With this update, the user can run these two metrics, without interfering with other metrics.

@ftshijt
Copy link
Copy Markdown
Contributor

ftshijt commented Jun 20, 2025

Thanks for the great effort! The current implementation looks very good. To further proceed, it would be super if you could:

  • register your metric in docs/supported_metrics.md
  • add a unit test at test/test_metrics/test_<metric_name>.py to enable unit test

@nezihtopaloglu
Copy link
Copy Markdown
Contributor Author

Hi @ftshijt, any updates?

@ftshijt
Copy link
Copy Markdown
Contributor

ftshijt commented Jun 30, 2025

Hi @ftshijt, any updates?

Hi @nezihtopaloglu , thanks for the update. Could you please fix the CI error? I think the current issue can be easily fixed with "black test versa" (you can conduct pip install black to get black setup).

@ftshijt
Copy link
Copy Markdown
Contributor

ftshijt commented Jul 1, 2025

Many thanks for your great contribution!

@ftshijt ftshijt merged commit cf03ef2 into wavlab-speech:main Jul 1, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants