Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 179/AdjustedLast #180

Merged
merged 3 commits into from
Nov 16, 2024
Merged

Issue 179/AdjustedLast #180

merged 3 commits into from
Nov 16, 2024

Conversation

crwpenn
Copy link
Contributor

@crwpenn crwpenn commented Nov 15, 2024

Adds AdjustedLast to market_data::historical::WhatToShow and also adds an example to document that WhatToShow::AdjustedLast can only be used with historical_data_ending_now() and not with historical_data()

@wboayue
Copy link
Owner

wboayue commented Nov 16, 2024

Looks good. 👍
Thanks for that. I'll add to the next release.

@wboayue wboayue merged commit 8dc6fd6 into wboayue:main Nov 16, 2024
1 check passed
@wboayue wboayue linked an issue Nov 16, 2024 that may be closed by this pull request
@crwpenn
Copy link
Contributor Author

crwpenn commented Nov 16, 2024

Looks good. 👍 Thanks for that. I'll add to the next release.

Thank you very much! Appreciate the quick review and all of your work to create this project. It's exactly what I needed.

@crwpenn crwpenn deleted the AdjustedLast branch November 17, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ADJUSTED_LAST is missing from Historical Data Types (whatToShow)
2 participants