Cleanup custom logging classes #418
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarrow
reviewed
Feb 2, 2024
| 'badpass-priv', | ||
| 'api-warning', | ||
| ], | ||
| 'logAllInGroupExceptDebug' => [ |
There was a problem hiding this comment.
I believe this may now be ignored when before it wasn't. This being info level log lines explaining that a user was on a IP block list (which we want to log so we can tell users what to do when they complain)
tarrow
reviewed
Feb 2, 2024
| 'objectcache',// ideally want to show objectcache errors, but not warnings | ||
| ], | ||
| 'logAllInGroup' => [ | ||
| 'WBSTACK', |
There was a problem hiding this comment.
I believe previously all debug and info level things in this group were logged where as now they will not be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.