Replace Terms of Use checkbox in Instance Creation workflow #1042
Conversation
|
Deployment previews on netlify for branch
|
| </v-radio> | ||
| </v-radio-group> | ||
|
|
||
| <h3 v-if="showTerms" class="mt-6">Terms of Use</h3> |
There was a problem hiding this comment.
Looking at Anton's mockup in the ticket, the ToU heading should remain (I guess just without the v-if="showTerms")
| </v-checkbox> | ||
| <div> | ||
| Previously accepted | ||
| <v-tooltip bottom> |
There was a problem hiding this comment.
If we can get the max-width of the card to be bigger, I like having the tooltip above the link - there is more space there.
| <div> | ||
| Previously accepted | ||
| <v-tooltip bottom> | ||
| <template v-slot:activator="{ on }"> | ||
| <a | ||
| target="_blank" | ||
| href="/terms-of-use" | ||
| @click.stop | ||
| v-on="on" | ||
| > | ||
| Terms of Use</a> | ||
| </template> | ||
| Opens in new window | ||
| </v-tooltip> still apply. | ||
| </div> |
There was a problem hiding this comment.
The text here is smaller than the rest of the form and Anton's mockup. A text-body-1 class on the div should do the trick. However, is the text intentionally smaller because it doesn't fit on a single line otherwise?
Let's ask UX if we should use a smaller font size or can increase the max-width of this card to 400px (technically 395px is the minimum it has to be for the text to fit).
There was a problem hiding this comment.
I've asked here: https://phabricator.wikimedia.org/T404988#11209512
Bug: T404988