Skip to content

ci: cancel PR workflows on new commits #4918

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2025

Conversation

erikgb
Copy link
Contributor

@erikgb erikgb commented Apr 8, 2025

Closes

What changed?

This change should ensure all PR workflows are cancelled when new commits are added to the PR branch. This improvement is already suggested in #3733, but I think the proposed syntax in that PR is incorrect. The PR also has conflicts that need to be resolved.

Close #3733

Why was this change made?

I want to add CI that eventually will update release-please PR branches to include doc updates in the release PR. This seems to be the suggested approach, ref. googleapis/release-please#2022 (comment).

Not wasting workflow resources appears like a good idea.

How was this change implemented?

How did you validate the change?

Release notes

Documentation Changes

@erikgb erikgb requested a review from casibbald April 8, 2025 19:38
@erikgb erikgb force-pushed the cancel-in-progress branch from 64626f0 to da3ffdf Compare April 13, 2025 16:18
@erikgb erikgb force-pushed the cancel-in-progress branch from da3ffdf to d2cbd93 Compare May 16, 2025 18:15
@erikgb erikgb enabled auto-merge (squash) May 16, 2025 18:15
@erikgb erikgb merged commit 39c0fd3 into weaveworks:main May 16, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants