feat(web-integration): implement file upload functionality with tests and HTML fixture #1709
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and HTML fixture
✅ Deploy Preview for midscene ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
quanru
changed the title
…meters and examples
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements file upload functionality for web automation testing, adding a new aiUploadFile action method that allows uploading single or multiple files to web pages through Puppeteer and Playwright interfaces.
- Adds
aiUploadFilemethod to the Agent API for uploading files via natural language element location - Implements uploadFile functionality in base page classes for Puppeteer and Playwright with file path validation
- Includes comprehensive test coverage for single file, multiple files, and error scenarios
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/agent/agent.ts | Adds aiUploadFile method to Agent class for file upload functionality |
| packages/core/src/device/index.ts | Defines UploadFile action schema and type definitions |
| packages/web-integration/src/web-page.ts | Registers UploadFile action in the common web actions |
| packages/web-integration/src/puppeteer/base-page.ts | Implements uploadFile method with file validation for both Puppeteer and Playwright |
| packages/web-integration/src/playwright/ai-fixture.ts | Adds aiUploadFile fixture for Playwright test integration |
| packages/web-integration/src/chrome-extension/page.ts | Adds uploadFile stub that throws descriptive error for unsupported Chrome Extension mode |
| packages/web-integration/tests/ai/web/puppeteer/file-upload.test.ts | Adds Puppeteer test suite for file upload scenarios |
| packages/web-integration/tests/ai/web/playwright/file-upload.spec.ts | Adds Playwright test suite for file upload scenarios |
| packages/web-integration/tests/ai/fixtures/file-upload.html | Provides HTML fixture for testing file upload interactions |
| packages/web-integration/tests/ai/fixtures/test-file*.txt | Adds test file fixtures for upload testing |
| apps/site/docs/en/api.mdx | Documents aiUploadFile API with examples in English |
| apps/site/docs/zh/api.mdx | Documents aiUploadFile API with examples in Chinese |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/web-integration/tests/ai/web/playwright/file-upload.spec.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/web-integration/tests/ai/web/puppeteer/file-upload.test.ts
Outdated
Show resolved
Hide resolved
packages/web-integration/tests/ai/web/playwright/file-upload.spec.ts
Outdated
Show resolved
Hide resolved
packages/web-integration/tests/ai/web/puppeteer/file-upload.test.ts
Outdated
Show resolved
Hide resolved
packages/web-integration/tests/ai/web/playwright/file-upload.spec.ts
Outdated
Show resolved
Hide resolved
…pec.ts Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yuyutaotao
reviewed
Jan 7, 2026
yuyutaotao
reviewed
Jan 7, 2026
* refactor(core): update the implementation of file uploader * refactor(core): update the implementation of file uploader * refactor(core): rename params
This reverts commit 2ea8890.
* refactor(core): update the implementation of file uploader * refactor(core): update the implementation of file uploader * refactor(core): rename params * docs(core): update aiAct * refactor(core): update the implementation of file uploader
yuyutaotao
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.