-
Notifications
You must be signed in to change notification settings - Fork 395
feat: server config hot reload #7264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 2872c36 The changes in this PR will be included in the next version bump. This PR includes changesets to release 295 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for modernjs-byted ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
import { | ||
createServer, | ||
setServer, | ||
setServerOptions, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setServer
and setServerOptions
is never used
@@ -12,5 +12,11 @@ export default (): CliPluginFuture<AppTools<'shared'>> => ({ | |||
], | |||
}, | |||
})); | |||
api._internalServerPlugins(({ plugins }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better create a new server plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Btw, this plugin should not be used in production
applyPluginsFn || applyPlugins, | ||
); | ||
|
||
server = newServer; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same logic as setServer
Summary
Related Links
Checklist
pnpm run change
.