Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source-build): ignore npm pkg source field #1508

Closed

Conversation

SoonIter
Copy link
Member

@SoonIter SoonIter commented Feb 4, 2024

Summary

Related Links

Checklist

  • Tests updated.
  • Documentation updated.

Copy link

netlify bot commented Feb 4, 2024

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit d4f521c
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/65bf5f537ccc460008ba3667
😎 Deploy Preview https://deploy-preview-1508--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SoonIter SoonIter force-pushed the fix/source-build-npm-pkg branch from 9a38928 to d4f521c Compare February 4, 2024 09:56
@SoonIter
Copy link
Member Author

SoonIter commented Feb 4, 2024

It's much more difficult than I thought... 😄,we have to add complex module.rules with monorepo topo graph
If we can modify the package.json read in resolve, it will become very simple.

@SoonIter
Copy link
Member Author

SoonIter commented Feb 4, 2024

https://pnpm.io/7.x/package_json#publishconfig

Maybe I can try this feature to remove the "source" field before publishing


I tried, pnpm only support overrides main bin etc field before pnpm pack with publishConfig

pnpm should support custom pkg-json fields

@SoonIter SoonIter closed this Feb 4, 2024
@chenjiahan
Copy link
Member

Yeah remove source field before publishing is hard.

We can try to use exports alternatives to support source code build after Rspack supporting it: web-infra-dev/rspack#5052 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants