Skip to content

feat: support for BROWSER_ARGS #4886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 3, 2025
Merged

Conversation

ianzone
Copy link
Contributor

@ianzone ianzone commented Mar 26, 2025

Summary

Related Links

#4879

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link

netlify bot commented Mar 26, 2025

Deploy Preview for rsbuild ready!

Name Link
🔨 Latest commit 3def65c
🔍 Latest deploy log https://app.netlify.com/sites/rsbuild/deploys/67eec3bf27b9560008f9f09f
😎 Deploy Preview https://deploy-preview-4886--rsbuild.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 77 (🟢 up 28 from production)
Accessibility: 97 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: 60 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@ianzone
Copy link
Contributor Author

ianzone commented Mar 29, 2025

还有啥要改的吗?

@ianzone
Copy link
Contributor Author

ianzone commented Mar 31, 2025

改了下浏览器名的匹配规则,更适应跨平台的情况

@ianzone
Copy link
Contributor Author

ianzone commented Apr 3, 2025

Well, now it should be a quick merge.

@chenjiahan chenjiahan changed the title feat: support BROWSER_ARGS feat: support for BROWSER_ARGS Apr 3, 2025
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@chenjiahan chenjiahan enabled auto-merge (squash) April 3, 2025 23:52
@chenjiahan chenjiahan merged commit 4896360 into web-infra-dev:main Apr 3, 2025
11 of 12 checks passed
@chenjiahan chenjiahan mentioned this pull request Apr 4, 2025
2 tasks
@ianzone ianzone deleted the browser branch April 4, 2025 09:51
@chenjiahan chenjiahan mentioned this pull request Apr 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants