Skip to content

chore: enable additional type-aware lint rules - #8282

Merged
chenjiahan merged 6 commits into
mainfrom
chenjiahan/chore-enable-more-type-aware-rules
Aug 17, 2026
Merged

chore: enable additional type-aware lint rules#8282
chenjiahan merged 6 commits into
mainfrom
chenjiahan/chore-enable-more-type-aware-rules

Conversation

@chenjiahan

@chenjiahan chenjiahan commented Aug 17, 2026

Copy link
Copy Markdown
Member

Summary

This PR enables six additional type-aware TypeScript lint rules to tighten async handling, error reporting, enum comparisons, stringification, and type definitions. Existing violations are fixed while preserving runtime behavior, with a targeted no-implied-eval suppression for the CJS runner's main-context dynamic import loader.

Related Links

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Aug 17, 2026

Copy link
Copy Markdown

Deploying rsbuild with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5eb2b91
Status: ✅  Deploy successful!
Preview URL: https://bfabb914.rsbuild-v2.pages.dev
Branch Preview URL: https://chenjiahan-chore-enable-more.rsbuild-v2.pages.dev

View logs

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5eb2b91c80

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/core/src/server/runner/cjs.ts Outdated

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 12d4e1ed43

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread packages/core/src/client/hmr.ts
@chenjiahan
chenjiahan merged commit 135e16c into main Aug 17, 2026
7 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/chore-enable-more-type-aware-rules branch August 17, 2026 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant