Skip to content

Commit

Permalink
chore(workflow): no need to run pnpm cache in rust jobs (#9430)
Browse files Browse the repository at this point in the history 
* chore(workflow): no need to run pnpm cache in rust check
  • Loading branch information
@chenjiahan
chenjiahan authored Feb 21, 2025
1 parent 7119e6a commit 4965098
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -212,9 +212,6 @@ jobs:
fmt: true
shared-key: check

- name: Pnpm Cache # Required by some tests
uses: ./.github/actions/pnpm-cache

- name: Run Cargo Check
run: cargo check --workspace --all-targets --locked # Not using --release because it uses too much cache, and is also slow.

Expand All @@ -231,7 +228,7 @@ jobs:
args: --all -- --check

- name: Run toml format check
run: pnpm run format-ci:toml
run: npm run format-ci:toml

rust_unused_dependencies:
name: Check Rust Unused Dependencies
Expand All @@ -255,9 +252,6 @@ jobs:
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4

- name: Pnpm Cache # Required by some tests
uses: ./.github/actions/pnpm-cache

- name: Install Rust Toolchain
uses: ./.github/actions/rustup
with:
Expand Down Expand Up @@ -288,9 +282,6 @@ jobs:
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4

- name: Pnpm Cache # Required by some tests
uses: ./.github/actions/pnpm-cache

- name: Install Rust Toolchain
uses: ./.github/actions/rustup
with:
Expand Down

2 comments on commit 4965098

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented on 4965098 Feb 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2025-02-21 18420bb) Current Change
10000_big_production-mode_disable-minimize + exec 36.6 s ± 380 ms 37.4 s ± 964 ms +2.16 %
10000_development-mode + exec 1.71 s ± 14 ms 1.69 s ± 13 ms -0.87 %
10000_development-mode_hmr + exec 671 ms ± 13 ms 667 ms ± 9.2 ms -0.53 %
10000_production-mode + exec 2.19 s ± 56 ms 2.21 s ± 236 ms +0.99 %
10000_production-mode_persistent-cold + exec 2.35 s ± 128 ms 2.29 s ± 74 ms -2.22 %
10000_production-mode_persistent-hot + exec 1.62 s ± 28 ms 1.62 s ± 55 ms +0.35 %
arco-pro_development-mode + exec 1.72 s ± 92 ms 1.74 s ± 92 ms +1.00 %
arco-pro_development-mode_hmr + exec 374 ms ± 1.2 ms 375 ms ± 4.2 ms +0.17 %
arco-pro_production-mode + exec 3.58 s ± 82 ms 3.54 s ± 185 ms -0.97 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.57 s ± 41 ms 3.57 s ± 213 ms -0.07 %
arco-pro_production-mode_persistent-cold + exec 3.67 s ± 287 ms 3.56 s ± 72 ms -2.83 %
arco-pro_production-mode_persistent-hot + exec 2.24 s ± 106 ms 2.33 s ± 155 ms +4.12 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.54 s ± 225 ms 3.54 s ± 158 ms -0.07 %
large-dyn-imports_development-mode + exec 1.97 s ± 37 ms 1.94 s ± 49 ms -1.47 %
large-dyn-imports_production-mode + exec 2.02 s ± 37 ms 2.02 s ± 85 ms +0.12 %
threejs_development-mode_10x + exec 1.48 s ± 140 ms 1.42 s ± 34 ms -4.27 %
threejs_development-mode_10x_hmr + exec 817 ms ± 22 ms 776 ms ± 7.7 ms -5.02 %
threejs_production-mode_10x + exec 5.14 s ± 161 ms 5.03 s ± 74 ms -2.11 %
threejs_production-mode_10x_persistent-cold + exec 5.15 s ± 352 ms 5.07 s ± 55 ms -1.54 %
threejs_production-mode_10x_persistent-hot + exec 4.49 s ± 273 ms 4.48 s ± 293 ms -0.34 %
10000_big_production-mode_disable-minimize + rss memory 8682 MiB ± 73.1 MiB 8697 MiB ± 67.6 MiB +0.17 %
10000_development-mode + rss memory 651 MiB ± 9.54 MiB 678 MiB ± 19.3 MiB +4.05 %
10000_development-mode_hmr + rss memory 1191 MiB ± 187 MiB 1234 MiB ± 307 MiB +3.66 %
10000_production-mode + rss memory 620 MiB ± 27.7 MiB 668 MiB ± 30.5 MiB +7.82 %
10000_production-mode_persistent-cold + rss memory 729 MiB ± 21.8 MiB 761 MiB ± 13.6 MiB +4.33 %
10000_production-mode_persistent-hot + rss memory 703 MiB ± 22.6 MiB 729 MiB ± 24.8 MiB +3.68 %
arco-pro_development-mode + rss memory 574 MiB ± 19.3 MiB 606 MiB ± 26.7 MiB +5.67 %
arco-pro_development-mode_hmr + rss memory 660 MiB ± 46.9 MiB 667 MiB ± 89.7 MiB +1.05 %
arco-pro_production-mode + rss memory 711 MiB ± 22.3 MiB 736 MiB ± 38.1 MiB +3.57 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 729 MiB ± 38.7 MiB 752 MiB ± 16.9 MiB +3.24 %
arco-pro_production-mode_persistent-cold + rss memory 789 MiB ± 47.8 MiB 806 MiB ± 28.7 MiB +2.19 %
arco-pro_production-mode_persistent-hot + rss memory 636 MiB ± 24.6 MiB 712 MiB ± 10.5 MiB +12.00 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 725 MiB ± 22.4 MiB 758 MiB ± 12.1 MiB +4.54 %
large-dyn-imports_development-mode + rss memory 644 MiB ± 5.16 MiB 674 MiB ± 5.94 MiB +4.75 %
large-dyn-imports_production-mode + rss memory 521 MiB ± 5.02 MiB 555 MiB ± 13.7 MiB +6.46 %
threejs_development-mode_10x + rss memory 572 MiB ± 30 MiB 579 MiB ± 37.9 MiB +1.18 %
threejs_development-mode_10x_hmr + rss memory 1128 MiB ± 228 MiB 1159 MiB ± 193 MiB +2.79 %
threejs_production-mode_10x + rss memory 851 MiB ± 78.3 MiB 872 MiB ± 37.6 MiB +2.44 %
threejs_production-mode_10x_persistent-cold + rss memory 957 MiB ± 45.2 MiB 976 MiB ± 17.8 MiB +2.02 %
threejs_production-mode_10x_persistent-hot + rss memory 811 MiB ± 63.4 MiB 848 MiB ± 53.9 MiB +4.54 %

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented on 4965098 Feb 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ecosystem CI detail: Open

suite result
modernjs ❌ failure
rspress ✅ success
rslib ✅ success
rsbuild ❌ failure
rsdoctor ❌ failure
examples ✅ success
devserver ✅ success
nuxt ✅ success

Please sign in to comment.