Skip to content

Commit

Permalink
fix: rspack sources perf bug (#9229)
Browse files Browse the repository at this point in the history 
* fix: rspack sources perf bug

* fix: upgrade rspack-sources
  • Loading branch information
@SyMind
SyMind authored Feb 11, 2025
1 parent f076b49 commit 548b20e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions Cargo.lock
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion Cargo.toml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ rayon = { version = "1.10.0" }
regex = { version = "1.11.1" }
ropey = "1.6.1"
rspack_resolver = { features = ["package_json_raw_json_api"], version = "0.5.0" }
rspack_sources = { version = "0.4.4" }
rspack_sources = { version = "0.4.5" }
rustc-hash = { version = "2.1.0" }
serde = { version = "1.0.217" }
serde_json = { version = "1.0.134" }
Expand Down

2 comments on commit 548b20e

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented on 548b20e Feb 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Benchmark detail: Open

Name Base (2025-02-11 9d82335) Current Change
10000_big_production-mode_disable-minimize + exec 37.7 s ± 637 ms 39.5 s ± 1.09 s +4.61 %
10000_development-mode + exec 1.88 s ± 89 ms 1.87 s ± 111 ms -0.44 %
10000_development-mode_hmr + exec 685 ms ± 7.4 ms 694 ms ± 29 ms +1.34 %
10000_production-mode + exec 2.28 s ± 51 ms 2.31 s ± 107 ms +1.33 %
10000_production-mode_persistent-cold + exec 2.47 s ± 72 ms 2.45 s ± 27 ms -0.70 %
10000_production-mode_persistent-hot + exec 1.65 s ± 61 ms 1.66 s ± 53 ms +0.89 %
arco-pro_development-mode + exec 1.78 s ± 145 ms 1.79 s ± 147 ms +0.54 %
arco-pro_development-mode_hmr + exec 389 ms ± 2.1 ms 388 ms ± 2.2 ms -0.27 %
arco-pro_production-mode + exec 3.59 s ± 217 ms 3.63 s ± 164 ms +1.10 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.72 s ± 229 ms 3.74 s ± 106 ms +0.49 %
arco-pro_production-mode_persistent-cold + exec 3.85 s ± 164 ms 3.75 s ± 173 ms -2.65 %
arco-pro_production-mode_persistent-hot + exec 2.36 s ± 99 ms 2.45 s ± 187 ms +3.95 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.63 s ± 69 ms 3.74 s ± 200 ms +3.05 %
large-dyn-imports_development-mode + exec 2.09 s ± 24 ms 2.13 s ± 34 ms +1.77 %
large-dyn-imports_production-mode + exec 2.15 s ± 71 ms 2.17 s ± 53 ms +0.80 %
threejs_development-mode_10x + exec 1.54 s ± 25 ms 1.55 s ± 41 ms +1.07 %
threejs_development-mode_10x_hmr + exec 779 ms ± 7 ms 785 ms ± 18 ms +0.81 %
threejs_production-mode_10x + exec 5.2 s ± 32 ms 5.27 s ± 113 ms +1.31 %
threejs_production-mode_10x_persistent-cold + exec 5.27 s ± 65 ms 5.35 s ± 346 ms +1.50 %
threejs_production-mode_10x_persistent-hot + exec 4.53 s ± 220 ms 4.53 s ± 135 ms 0.00 %
10000_big_production-mode_disable-minimize + rss memory 8706 MiB ± 32.4 MiB 8684 MiB ± 20.9 MiB -0.25 %
10000_development-mode + rss memory 649 MiB ± 12.6 MiB 667 MiB ± 13.8 MiB +2.78 %
10000_development-mode_hmr + rss memory 1344 MiB ± 112 MiB 1282 MiB ± 228 MiB -4.62 %
10000_production-mode + rss memory 621 MiB ± 21.8 MiB 653 MiB ± 15.9 MiB +5.20 %
10000_production-mode_persistent-cold + rss memory 746 MiB ± 24.7 MiB 752 MiB ± 24.2 MiB +0.70 %
10000_production-mode_persistent-hot + rss memory 717 MiB ± 23.3 MiB 740 MiB ± 11.5 MiB +3.20 %
arco-pro_development-mode + rss memory 569 MiB ± 17.5 MiB 583 MiB ± 16 MiB +2.50 %
arco-pro_development-mode_hmr + rss memory 643 MiB ± 49.1 MiB 642 MiB ± 75.8 MiB -0.13 %
arco-pro_production-mode + rss memory 714 MiB ± 28.8 MiB 715 MiB ± 34.5 MiB +0.13 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 732 MiB ± 22.4 MiB 723 MiB ± 28.9 MiB -1.23 %
arco-pro_production-mode_persistent-cold + rss memory 853 MiB ± 45.5 MiB 825 MiB ± 19.3 MiB -3.34 %
arco-pro_production-mode_persistent-hot + rss memory 708 MiB ± 27.8 MiB 707 MiB ± 30.8 MiB -0.16 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 727 MiB ± 48.2 MiB 709 MiB ± 24.1 MiB -2.46 %
large-dyn-imports_development-mode + rss memory 644 MiB ± 5.26 MiB 638 MiB ± 5.76 MiB -0.92 %
large-dyn-imports_production-mode + rss memory 526 MiB ± 7.84 MiB 524 MiB ± 6.53 MiB -0.48 %
threejs_development-mode_10x + rss memory 553 MiB ± 16.3 MiB 546 MiB ± 11.7 MiB -1.15 %
threejs_development-mode_10x_hmr + rss memory 1145 MiB ± 140 MiB 1092 MiB ± 212 MiB -4.56 %
threejs_production-mode_10x + rss memory 828 MiB ± 50.8 MiB 836 MiB ± 35.4 MiB +1.03 %
threejs_production-mode_10x_persistent-cold + rss memory 960 MiB ± 14.5 MiB 942 MiB ± 36.2 MiB -1.90 %
threejs_production-mode_10x_persistent-hot + rss memory 877 MiB ± 54.8 MiB 861 MiB ± 42.3 MiB -1.88 %

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented on 548b20e Feb 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 Ecosystem CI detail: Open

suite result
modernjs ❌ failure
rspress ✅ success
rslib ✅ success
rsbuild ❌ failure
rsdoctor ❌ failure
examples ✅ success
devserver ✅ success
nuxt ✅ success

Please sign in to comment.