cmt

web-infra-dev · Feb 21, 2025 · 6ba4488 · 6ba4488
1 parent 3c19f22
commit 6ba4488
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/crates/rspack_core/src/compiler/compilation.rs b/crates/rspack_core/src/compiler/compilation.rs
@@ -1250,6 +1250,10 @@ impl Compilation {
     }
 
     let start = logger.time("finish modules");
+    // finish_modules means the module graph (modules, connections, dependencies) are
+    // frozen and start to optimize (provided exports, infer async, etc.) based on the
+    // module graph, so any kind of change that affect these should be done before the
+    // finish_modules
     plugin_driver
       .compilation_hooks
       .finish_modules