fix(deps): govern graceful-fs sourcemap phantom dependencies (#9259)

* fix: govern graceful-fs dependency * fix: govern source-map dependency * refactor: add more ghost deps --------- Co-authored-by: pshu <[email protected]> Co-authored-by: pshu <[email protected]>
web-infra-dev · Feb 12, 2025 · 8b066ad · 8b066ad · github-actions · Feb 12, 2025
1 parent ec7546d
commit 8b066ad
Show file tree

Hide file tree

Showing 6 changed files with 64 additions and 42 deletions.
diff --git a/package.json b/package.json
@@ -85,7 +85,7 @@
   "packageManager": "[email protected]",
   "pnpm": {
     "patchedDependencies": {
-      "graceful-fs@4.2.10": "patches/graceful-fs@4.2.10.patch",
+      "graceful-fs": "patches/graceful-fs.patch",
       "rollup-plugin-dts": "patches/rollup-plugin-dts.patch"
     }
   }

diff --git a/packages/rspack-test-tools/package.json b/packages/rspack-test-tools/package.json
@@ -56,13 +56,17 @@
     "filenamify": "4.3.0",
     "fs-extra": "^11.3.0",
     "glob": "^11.0.0",
+    "graceful-fs": "^4.2.11",
     "jest-diff": "^29.7.0",
     "jest-snapshot": "29.7.0",
     "jsdom": "^26.0.0",
+    "loader-utils": "^2.0.4",
     "memfs": "4.17.0",
     "path-serializer": "0.3.4",
     "pretty-format": "29.7.0",
     "rimraf": "^5.0.10",
+    "source-map": "^0.7.4",
+    "terser-webpack-plugin": "^5.3.10",
     "webpack": "5.95.0",
     "webpack-merge": "5.9.0",
     "webpack-sources": "3.2.3"
@@ -74,6 +78,7 @@
     "@rspack/core": "workspace:*",
     "@rspack/plugin-preact-refresh": "1.1.0",
     "@rspack/plugin-react-refresh": "^1.0.1",
+    "@rspack/test-tools": "workspace:*",
     "@swc/helpers": "0.5.15",
     "@swc/plugin-remove-console": "^6.0.2",
     "@types/babel__generator": "7.6.8",
@@ -94,6 +99,7 @@
     "core-js": "3.38.1",
     "css-loader": "^7.1.2",
     "file-loader": "^6.2.0",
+    "graceful-fs": "^4.2.11",
     "html-loader": "^5.0.0",
     "html-webpack-plugin": "^5.5.0",
     "less-loader": "^12.2.0",
@@ -110,6 +116,7 @@
     "react-refresh": "^0.16.0",
     "sass-embedded": "^1.77.8",
     "sass-loader": "^16.0.0",
+    "source-map": "^0.7.4",
     "source-map-loader": "^5.0.0",
     "style-loader": "^4.0.0",
     "terser": "5.38.1",

diff --git a/packages/rspack/package.json b/packages/rspack/package.json
@@ -58,7 +58,7 @@
     "browserslist": "^4.21.3",
     "cross-env": "^7.0.3",
     "enhanced-resolve": "5.18.1",
-    "graceful-fs": "4.2.11",
+    "graceful-fs": "^4.2.11",
     "json-parse-even-better-errors": "^3.0.0",
     "prebundle": "^1.2.7",
     "tsc-alias": "^1.8.8",

diff --git a/patches/[email protected] → patches/graceful-fs.patch b/patches/[email protected] → patches/graceful-fs.patch
Name	Base (2025-02-12 03cc6cf)	Current	Change
10000_big_production-mode_disable-minimize + exec	38.8 s ± 1.01 s	39 s ± 907 ms	+0.49 %
10000_development-mode + exec	1.88 s ± 100 ms	1.85 s ± 80 ms	-1.46 %
10000_development-mode_hmr + exec	685 ms ± 6.4 ms	690 ms ± 12 ms	+0.75 %
10000_production-mode + exec	2.34 s ± 90 ms	2.31 s ± 97 ms	-1.12 %
10000_production-mode_persistent-cold + exec	2.45 s ± 62 ms	2.44 s ± 29 ms	-0.41 %
10000_production-mode_persistent-hot + exec	1.68 s ± 167 ms	1.67 s ± 111 ms	-0.31 %
arco-pro_development-mode + exec	1.82 s ± 103 ms	1.71 s ± 75 ms	-5.86 %
arco-pro_development-mode_hmr + exec	389 ms ± 1.9 ms	387 ms ± 1.2 ms	-0.58 %
arco-pro_production-mode + exec	3.63 s ± 161 ms	3.67 s ± 137 ms	+1.30 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.71 s ± 33 ms	3.75 s ± 174 ms	+0.91 %
arco-pro_production-mode_persistent-cold + exec	3.81 s ± 223 ms	3.81 s ± 107 ms	+0.02 %
arco-pro_production-mode_persistent-hot + exec	2.32 s ± 52 ms	2.39 s ± 187 ms	+3.24 %
arco-pro_production-mode_traverse-chunk-modules + exec	3.7 s ± 122 ms	3.76 s ± 289 ms	+1.57 %
large-dyn-imports_development-mode + exec	2.16 s ± 38 ms	2.14 s ± 165 ms	-0.76 %
large-dyn-imports_production-mode + exec	2.16 s ± 27 ms	2.16 s ± 39 ms	-0.01 %
threejs_development-mode_10x + exec	1.57 s ± 49 ms	1.54 s ± 18 ms	-2.38 %
threejs_development-mode_10x_hmr + exec	788 ms ± 7.2 ms	778 ms ± 12 ms	-1.34 %
threejs_production-mode_10x + exec	5.24 s ± 88 ms	5.22 s ± 136 ms	-0.55 %
threejs_production-mode_10x_persistent-cold + exec	5.3 s ± 81 ms	5.35 s ± 167 ms	+0.97 %
threejs_production-mode_10x_persistent-hot + exec	4.54 s ± 144 ms	4.57 s ± 261 ms	+0.58 %
10000_big_production-mode_disable-minimize + rss memory	8691 MiB ± 24.9 MiB	8723 MiB ± 77.7 MiB	+0.36 %
10000_development-mode + rss memory	656 MiB ± 28.5 MiB	639 MiB ± 26.3 MiB	-2.71 %
10000_development-mode_hmr + rss memory	1286 MiB ± 174 MiB	1318 MiB ± 208 MiB	+2.49 %
10000_production-mode + rss memory	627 MiB ± 20.1 MiB	624 MiB ± 7.29 MiB	-0.44 %
10000_production-mode_persistent-cold + rss memory	740 MiB ± 25.8 MiB	742 MiB ± 19.5 MiB	+0.25 %
10000_production-mode_persistent-hot + rss memory	717 MiB ± 25.4 MiB	729 MiB ± 17 MiB	+1.65 %
arco-pro_development-mode + rss memory	560 MiB ± 17.8 MiB	566 MiB ± 37.1 MiB	+1.16 %
arco-pro_development-mode_hmr + rss memory	637 MiB ± 83 MiB	655 MiB ± 67.1 MiB	+2.69 %
arco-pro_production-mode + rss memory	716 MiB ± 24.8 MiB	712 MiB ± 43.9 MiB	-0.63 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory	727 MiB ± 15.4 MiB	734 MiB ± 22.4 MiB	+0.94 %
arco-pro_production-mode_persistent-cold + rss memory	837 MiB ± 63.8 MiB	848 MiB ± 40.4 MiB	+1.35 %
arco-pro_production-mode_persistent-hot + rss memory	706 MiB ± 19.6 MiB	715 MiB ± 20.8 MiB	+1.24 %
arco-pro_production-mode_traverse-chunk-modules + rss memory	735 MiB ± 23.3 MiB	716 MiB ± 23.5 MiB	-2.55 %
large-dyn-imports_development-mode + rss memory	640 MiB ± 5.5 MiB	642 MiB ± 9.33 MiB	+0.27 %
large-dyn-imports_production-mode + rss memory	527 MiB ± 6.62 MiB	529 MiB ± 2.86 MiB	+0.36 %
threejs_development-mode_10x + rss memory	546 MiB ± 15.1 MiB	546 MiB ± 9.02 MiB	+0.02 %
threejs_development-mode_10x_hmr + rss memory	1183 MiB ± 111 MiB	1164 MiB ± 48.9 MiB	-1.55 %
threejs_production-mode_10x + rss memory	834 MiB ± 45 MiB	842 MiB ± 38.9 MiB	+0.96 %
threejs_production-mode_10x_persistent-cold + rss memory	962 MiB ± 46.9 MiB	955 MiB ± 30.8 MiB	-0.75 %
threejs_production-mode_10x_persistent-hot + rss memory	878 MiB ± 35 MiB	878 MiB ± 26.2 MiB	+0.08 %
suite	result
modernjs	✅ success
rspress	✅ success
rslib	✅ success
rsbuild	❌ failure
rsdoctor	❌ failure
examples	✅ success
devserver	✅ success
nuxt	✅ success