fix: namedChunks / emitAsset js api (#9185)

* fix: namedChunks

* fix: emit_asset a absolute path

* chore: case for node_join

* fix: LibManifestPlugin should use intermediate_filesystem

* chore: more test case for node_join

* fix: should convert absolute filename into relative

* fix: clippy

* fix: error in windows

* refactor: node path trait impl

* fix: cargo clippy

* fix: node_join in Utf8Path

crates/node_binding/binding.d.ts

@@ -105,7 +105,7 @@ export declare class JsCompilation {
   getOptimizationBailout(): Array<JsStatsOptimizationBailout>
   getChunks(): JsChunk[]
   getNamedChunkKeys(): Array<string>
-  getNamedChunk(name: string): JsChunk
+  getNamedChunk(name: string): JsChunk | null
   getNamedChunkGroupKeys(): Array<string>
   getNamedChunkGroup(name: string): JsChunkGroup
   setAssetSource(name: string, source: JsCompatSource): void

crates/rspack_binding_values/src/compilation/mod.rs

@@ -240,7 +240,7 @@ impl JsCompilation {
     Ok(compilation.named_chunks.keys().cloned().collect::<Vec<_>>())
   }
 
-  #[napi(ts_return_type = "JsChunk")]
+  #[napi(ts_return_type = "JsChunk | null")]
   pub fn get_named_chunk(&self, name: String) -> Result<Option<JsChunkWrapper>> {
     let compilation = self.as_ref()?;
 

crates/rspack_core/src/compiler/mod.rs

@@ -10,6 +10,7 @@ use rspack_futures::FuturesResults;
 use rspack_hook::define_hook;
 use rspack_paths::{Utf8Path, Utf8PathBuf};
 use rspack_sources::BoxSource;
+use rspack_util::node_path::NodePath;
 use rustc_hash::FxHashMap as HashMap;
 use tracing::instrument;
 
@@ -358,7 +359,7 @@ impl Compiler {
   ) -> Result<()> {
     if let Some(source) = asset.get_source() {
       let (target_file, query) = filename.split_once('?').unwrap_or((filename, ""));
-      let file_path = output_path.join(target_file);
+      let file_path = output_path.node_join(target_file);
       self
         .output_filesystem
         .create_dir_all(

crates/rspack_plugin_dll/Cargo.toml

@@ -13,6 +13,7 @@ rspack_collections      = { workspace = true }
 rspack_core             = { workspace = true }
 rspack_error            = { workspace = true }
 rspack_hook             = { workspace = true }
+rspack_paths            = { workspace = true }
 rspack_plugin_externals = { workspace = true }
 rspack_util             = { workspace = true }
 

crates/rspack_plugin_dll/src/lib_manifest_plugin.rs

@@ -1,15 +1,11 @@
-use std::collections::HashSet;
-use std::sync::Arc;
-
 use rspack_collections::DatabaseItem;
 use rspack_core::{
-  rspack_sources::{BoxSource, RawStringSource},
-  ApplyContext, ChunkGraph, Compilation, CompilationAssets, CompilerEmit, CompilerOptions, Context,
-  EntryDependency, Filename, LibIdentOptions, PathData, Plugin, PluginContext, ProvidedExports,
-  SourceType,
+  ApplyContext, ChunkGraph, Compilation, CompilerEmit, CompilerOptions, Context, EntryDependency,
+  Filename, LibIdentOptions, PathData, Plugin, PluginContext, ProvidedExports, SourceType,
 };
 use rspack_error::{Error, Result};
 use rspack_hook::{plugin, plugin_hook};
+use rspack_paths::Utf8Path;
 use rustc_hash::FxHashMap as HashMap;
 
 use crate::{
@@ -56,11 +52,9 @@ impl Plugin for LibManifestPlugin {
 
 #[plugin_hook(CompilerEmit for LibManifestPlugin)]
 async fn emit(&self, compilation: &mut Compilation) -> Result<()> {
-  let mut use_paths: HashSet<String> = HashSet::new();
-
   let chunk_graph = &compilation.chunk_graph;
 
-  let mut manifests: CompilationAssets = HashMap::default();
+  let mut manifests: HashMap<String, String> = HashMap::default();
 
   let module_graph = compilation.get_module_graph();
 
@@ -84,12 +78,10 @@ async fn emit(&self, compilation: &mut Compilation) -> Result<()> {
         .chunk_name_optional(chunk.name_for_filename_template(&compilation.chunk_ids_artifact)),
     )?;
 
-    if use_paths.contains(&target_path) {
+    if manifests.contains_key(&target_path) {
       return Err(Error::msg("each chunk must have a unique path"));
     }
 
-    use_paths.insert(target_path.clone());
-
     let name = self.options.name.as_ref().and_then(|name| {
       compilation
         .get_path(
@@ -175,13 +167,16 @@ async fn emit(&self, compilation: &mut Compilation) -> Result<()> {
       serde_json::to_string(&manifest).map_err(|e| Error::msg(format!("{e}")))?
     };
 
-    let asset = Arc::new(RawStringSource::from(manifest_json)) as BoxSource;
-
-    manifests.insert(target_path, asset.into());
+    manifests.insert(target_path, manifest_json);
   }
 
-  for (filename, asset) in manifests {
-    compilation.emit_asset(filename, asset);
+  let intermediate_filesystem = compilation.intermediate_filesystem.as_ref();
+  for (filename, json) in manifests {
+    let path = Utf8Path::new(&filename);
+    if let Some(dir) = path.parent() {
+      intermediate_filesystem.create_dir_all(dir).await?;
+    }
+    intermediate_filesystem.write(path, json.as_bytes()).await?;
   }
 
   Ok(())

crates/rspack_plugin_html/src/plugin.rs

@@ -1,4 +1,8 @@
-use std::{path::PathBuf, sync::LazyLock};
+use std::{
+  borrow::Cow,
+  path::{Path, PathBuf},
+  sync::LazyLock,
+};
 
 use cow_utils::CowUtils;
 use rspack_core::{
@@ -8,6 +12,7 @@ use rspack_core::{
 use rspack_error::{miette, Diagnostic, Result};
 use rspack_hook::{plugin, plugin_hook};
 use rspack_util::fx_hash::FxDashMap;
+use sugar_path::SugarPath;
 use swc_html::visit::VisitMutWith;
 
 use crate::{
@@ -181,26 +186,48 @@ async fn process_assets(&self, compilation: &mut Compilation) -> Result<()> {
 
   // TODO: parallel generate html
   for filename in &config.filename {
-    let output_file_name = FilenameTemplate::from(
-      filename
-        .cow_replace("[templatehash]", "[contenthash]")
-        .into_owned(),
-    );
-
-    let (template_file_name, html) =
-      match generate_html(filename, &output_file_name, config, compilation, &hooks).await {
-        Ok(content) => {
-          compilation
-            .file_dependencies
-            .extend(content.2.into_iter().map(Into::into));
-          (content.0, content.1)
-        }
-        Err(err) => {
-          let error_msg = err.to_string();
-          compilation.push_diagnostic(Diagnostic::from(err));
-          ("error.html".to_string(), create_error_html(&error_msg))
-        }
-      };
+    let filename = filename.cow_replace("[templatehash]", "[contenthash]");
+
+    // convert absolute filename into relative so that webpack can
+    // generate it at correct location
+    let filename = {
+      let filename_path = Path::new(filename.as_ref());
+      if filename_path.is_absolute() {
+        let output_path = &compilation.options.output.path;
+        Cow::from(
+          filename_path
+            .relative(output_path)
+            .to_string_lossy()
+            .to_string(),
+        )
+      } else {
+        filename
+      }
+    };
+
+    let output_file_name = FilenameTemplate::from(filename.to_string());
+
+    let (template_file_name, html) = match generate_html(
+      filename.as_ref(),
+      &output_file_name,
+      config,
+      compilation,
+      &hooks,
+    )
+    .await
+    {
+      Ok(content) => {
+        compilation
+          .file_dependencies
+          .extend(content.2.into_iter().map(Into::into));
+        (content.0, content.1)
+      }
+      Err(err) => {
+        let error_msg = err.to_string();
+        compilation.push_diagnostic(Diagnostic::from(err));
+        ("error.html".to_string(), create_error_html(&error_msg))
+      }
+    };
 
     let mut before_emit_data = hooks
       .before_emit

crates/rspack_util/Cargo.toml

@@ -18,6 +18,7 @@ itoa             = { version = "1.0.14" }
 regex            = { workspace = true }
 ropey            = { workspace = true }
 rspack_cacheable = { workspace = true }
+rspack_paths     = { workspace = true }
 rustc-hash       = { workspace = true }
 serde            = { workspace = true }
 serde_json       = { workspace = true }

crates/rspack_util/src/lib.rs

@@ -12,6 +12,7 @@ pub mod identifier;
 pub mod infallible;
 pub mod itoa;
 pub mod location;
+pub mod node_path;
 pub mod number_hash;
 pub mod queue;
 pub mod size;