Skip to content

Commit

Permalink
chore(workflow): no need to run pnpm cache when building binary
Browse files Browse the repository at this point in the history
  • Loading branch information
chenjiahan committed Feb 21, 2025
1 parent f7ec690 commit d7bdc51
Showing 1 changed file with 4 additions and 10 deletions.
14 changes: 4 additions & 10 deletions .github/workflows/reusable-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -60,12 +60,6 @@ jobs:
with:
target: ${{ inputs.target }}

- name: Pnpm Cache
if: ${{ !inputs.skipable }}
uses: ./.github/actions/pnpm-cache
with:
save-if: ${{ github.ref_name == 'main' }}

- name: Install Rust Toolchain
if: ${{ !inputs.skipable }}
uses: ./.github/actions/rustup
Expand Down Expand Up @@ -260,7 +254,7 @@ jobs:
PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD: true
# TODO: use puppeteer to test SRI Plugin, maybe find a better performance way
# PUPPETEER_SKIP_DOWNLOAD: true

steps:
- name: Checkout
if: ${{ !inputs.skipable }}
Expand Down Expand Up @@ -379,7 +373,7 @@ jobs:
with:
save-cache: ${{ github.ref_name == 'main' }} # This should be safe because we have nightly building the cache every day
shared-key: build-bench-${{ inputs.target }}-${{ inputs.profile }}

- name: Install cargo-codspeed binary
uses: taiki-e/install-action@54b836426b3fa9aef432e760885ea0419ab50dab # v2
with:
Expand All @@ -394,10 +388,10 @@ jobs:
uses: lewagon/[email protected]
with:
ref: ${{ github.event.pull_request.head.sha || github.sha }}
check-name: 'Test Linux / Build'
check-name: "Test Linux / Build"
repo-token: ${{ secrets.GITHUB_TOKEN }}
wait-interval: 10

- name: Download bindings
uses: ./.github/actions/download-artifact
with:
Expand Down

0 comments on commit d7bdc51

Please sign in to comment.