fix: persistent cache remove non-existent modules from make_failed_mo…

…dule (#9309) fix: cache remove non-existent modules from make_failed_module
web-infra-dev · Feb 14, 2025 · f34377a · f34377a · github-actions · Feb 14, 2025
1 parent b7b7c3e
commit f34377a
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/crates/rspack_core/src/cache/persistent/occasion/make/mod.rs b/crates/rspack_core/src/cache/persistent/occasion/make/mod.rs
@@ -90,6 +90,12 @@ impl MakeOccasion {
     artifact.build_dependencies = build_dep;
     artifact.reset_dependencies_incremental_info();
 
+    // TODO remove it after all of module are cacheable
+    let mut make_failed_module = std::mem::take(&mut artifact.make_failed_module);
+    let mg = artifact.get_module_graph_mut();
+    make_failed_module.retain(|module_id| mg.module_by_identifier(module_id).is_some());
+    artifact.make_failed_module = make_failed_module;
+
     Ok(artifact)
   }
 }