Skip to content

fix(diagnostic): fix excessively large width causing format_args panics #10109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025

Conversation

h-a-n-a
Copy link
Contributor

@h-a-n-a h-a-n-a commented Apr 21, 2025

Summary

This PR fixes the panic when calling format_args! with excessively large width (> u16::MAX), which is an constraint introduced in rust PR rust-lang/rust#99012.

This is not an ideal way for handling a minimized source code. The way of printing diagnostics of minimized source remains to be discussed.

closes #9971

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Apr 21, 2025
Copy link

netlify bot commented Apr 21, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 392a616
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/68061b8f15bc3a000878d081

@h-a-n-a h-a-n-a marked this pull request as ready for review April 21, 2025 10:19
@h-a-n-a h-a-n-a enabled auto-merge (squash) April 21, 2025 10:19
@h-a-n-a h-a-n-a requested a review from chenjiahan April 21, 2025 10:26
Copy link

codspeed-hq bot commented Apr 21, 2025

CodSpeed Performance Report

Merging #10109 will not alter performance

Comparing fix/miette (392a616) with main (db1fb0e)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@h-a-n-a h-a-n-a merged commit ad4ba18 into main Apr 21, 2025
31 checks passed
@h-a-n-a h-a-n-a deleted the fix/miette branch April 21, 2025 10:46
@jtsorlinis
Copy link

This PR has broken our builds, we now get
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Vue builds errors in version 1.3.4
3 participants