Skip to content

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Aug 21, 2025

Summary

Port: webpack/webpack#19818

let m = await import("./m");
m.a; // a is used, rest can be tree-shaken
m.f() // f is used, rest can be tree-shaken if strictThisContextOnImports = false
m // m namespace is used, can't be tree-shaken

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Aug 21, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit c6aee92
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/68ba86e2f863870008a991bc
😎 Deploy Preview https://deploy-preview-11457--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Aug 21, 2025
Copy link
Contributor

github-actions bot commented Aug 21, 2025

📦 Binary Size-limit

Comparing c6aee92 to perf: improve deterministic chunk ids (#11575) by harpsealjs

❌ Size increased by 18.38KB from 47.24MB to 47.26MB (⬆️0.04%)

Copy link

codspeed-hq bot commented Aug 25, 2025

CodSpeed Performance Report

Merging #11457 will not alter performance

Comparing tree-shake-statical-dynamic-import (c6aee92) with main (bfed4d2)1

Summary

✅ 17 untouched benchmarks

Footnotes

  1. No successful run was found on main (15ba68e) during the generation of this report, so bfed4d2 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@ahabhgk ahabhgk marked this pull request as ready for review August 25, 2025 07:50
@Copilot Copilot AI review requested due to automatic review settings August 25, 2025 07:50
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@ahabhgk
Copy link
Contributor Author

ahabhgk commented Aug 28, 2025

Need to refactor JavaScriptParser.dependencies API before merge, I don't feel good for now we directly access the JavaScriptParser.dependencies

@ahabhgk ahabhgk enabled auto-merge (squash) September 5, 2025 07:02
@ahabhgk ahabhgk merged commit 3d387ee into main Sep 5, 2025
72 of 74 checks passed
@ahabhgk ahabhgk deleted the tree-shake-statical-dynamic-import branch September 5, 2025 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants