-
-
Notifications
You must be signed in to change notification settings - Fork 782
feat(browser): add postprocess
and ResolvedRequest
to BrowserHttpImportEsmPlugin
#11571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
📦 Binary Size-limit
🙈 Size remains the same at 47.24MB |
CodSpeed Performance ReportMerging #11571 will not alter performanceComparing Summary
|
postprocess
and ResolvedRequest
to BrowserHttpImportEsmPlugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the BrowserHttpImportEsmPlugin
by adding a postprocessing hook and providing more detailed request information to plugin options. The changes enable users to attach CDN-specific query parameters and access comprehensive request context.
- Add
postprocess
hook allowing users to modify the URL with CDN-specific parameters - Introduce
ResolvedRequest
andProcessedRequest
interfaces for better type safety and information access - Refactor function signatures to accept
ResolvedRequest
objects instead of separate parameters
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Summary
postprocess
hook where users can attach cdn queries to the url likerequest.url.searchParams.set("external", "react");
ResolvedRequest
to provide more information for the function options.Checklist