perf: reuse module concatenation search state#14833
Open
LingyuCoder wants to merge 1 commit into
Open
Conversation
2 tasks
LingyuCoder
changed the title
2 tasks
Contributor
|
📝 Benchmark detail: Open
Base persistent cache hit rate: 👍 Current persistent cache hit rate: 👍 |
Contributor
📦 Binary Size-limit
⏳ The base commit triggered a linux binding build, but its binary size data has not been generated yet, so the size comparison is skipped. Please re-run this workflow once the ecosystem-benchmark data for that commit is published. Warning Reference only — not the real baseline. The base commit's data isn't ready yet, so this compares against the nearest earlier commit that has data ( ❌ Size increased by 8.00KB from 66.66MB to 66.67MB (⬆️0.01%) |
Contributor
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Contributor
Merging this PR will improve performance by 20.31%
|
| Mode | Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|---|
| ⚡ | Simulation | sources@parse_source_map_from_json |
9.9 ms | 7.5 ms | +32.87% |
| ⚡ | Simulation | rust@create_concatenate_module_shared_roots |
22.3 ms | 17.8 ms | +24.79% |
| ⚡ | Simulation | rust@create_concatenate_module_unsupported_syntax |
22.4 ms | 18.1 ms | +23.53% |
| ⚡ | Simulation | rust@create_concatenate_module |
13.8 ms | 13.5 ms | +2.28% |
Tip
Curious why this is faster? Comment @codspeedbot explain why this is faster on this PR, or directly use the CodSpeed MCP with your agent.
Comparing seal/module-concat-search-state (5bd606d) with seal/module-concat-runtime-cache (9924a3e)2
Footnotes
-
47 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩
-
No successful run was found on
seal/module-concat-runtime-cache(eff6ba1) during the generation of this report, so e027df6 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩
Reuse per-root search scratch state, share immutable bailout payloads, and defer warning materialization until needed. Keep runtime-dependent analysis cached while reducing transient allocations in the concatenation search. Co-authored-by: ScriptedAlchemy <zackary.l.jackson@gmail.com>
LingyuCoder
force-pushed
the
seal/module-concat-runtime-cache
branch
from
July 21, 2026 07:44
9924a3e to
eff6ba1
Compare
LingyuCoder
force-pushed
the
seal/module-concat-search-state
branch
from
July 21, 2026 07:44
6e442e8 to
5bd606d
Compare
Deploying rspack with
|
| Latest commit: |
5bd606d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7d8a4b2e.rspack-v2.pages.dev |
| Branch Preview URL: | https://seal-module-concat-search-st.rspack-v2.pages.dev |
LingyuCoder
marked this pull request as ready for review
July 21, 2026 07:50
JSerFeng
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related links
Checklist