fix: avoid emitting JavaScript for CSS-only entries#14879
Draft
intellild wants to merge 1 commit into
Draft
Conversation
Contributor
📦 Binary Size-limit
🙈 Size remains the same at 66.64MB |
Contributor
Rsdoctor Bundle Diff Analysis
Found 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
Contributor
Merging this PR will not alter performance
Comparing Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Example
Given a CSS-only entry:
Rspack previously emitted both
styles.cssand an unnecessarystyles.js. After this change it emits onlystyles.css. If JavaScript imports the CSS module and needs its exports, the JavaScript facade is still generated. JavaScript-valued CSS export types such astext,style, andCSSStyleSheetkeep their existing behavior.Root cause
The JavaScript render manifest considered every entry chunk to contain JavaScript, even when its modules exposed no
SourceType::JavaScript. Runtime chunks were also retained merely because runtime modules existed, without checking whether the entrypoint group had a JavaScript consumer.Related links
Validation
pnpm run build:cli:devpnpm run test -t "only-entry"pnpm run test -t "entry-with-runtimeChunk"cargo clippy -p rspack_plugin_css -p rspack_plugin_javascript --all-targets -- -D warningscargo fmt --all --checkChecklist
by OpenAI Codex