Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(type): export resource data with data type and add docs #9107

Merged

Conversation

LonelySnowman
Copy link
Contributor

@LonelySnowman LonelySnowman commented Jan 23, 2025

Summary

  • 在开发 Rspack 插件时发现 NormalModuleFactory 的 resolveForScheme 钩子文档使用示例代码有误,并且缺少类型的导出。
  • 仅改动文档与类型导出。

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@CLAassistant
Copy link

CLAassistant commented Jan 23, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for rspack ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit de62287
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67a379152636db00080962fe
😎 Deploy Preview https://deploy-preview-9107--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Jan 23, 2025

CodSpeed Performance Report

Merging #9107 will not alter performance

Comparing LonelySnowman:fix/resolve-scheme-error (de62287) with main (1b119cb)

Summary

✅ 6 untouched benchmarks

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Can you run pnpm api-extractor:local to update the API snapshots?

@LonelySnowman
Copy link
Contributor Author

Thank you for your contribution! Can you run to update the API snapshots?pnpm api-extractor:local

Done, No changes to the api snapshot after running.

@chenjiahan
Copy link
Member

Based on the CI result, there should be some snapshot updates. Can you try to run pnpm build:cli:debug && pnpm api-extractor:local?

@LonelySnowman
Copy link
Contributor Author

@chenjiahan Done, It works after run pnpm build:cli:debug.

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@chenjiahan chenjiahan merged commit f483667 into web-infra-dev:main Feb 6, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants