Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(deps): update swc_core to v13 #9133

Merged
merged 9 commits into from
Feb 6, 2025
Merged

perf(deps): update swc_core to v13 #9133

merged 9 commits into from
Feb 6, 2025

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Jan 27, 2025 •
edited
Loading

This upgrade will not break SWC Wasm plugin, so it's not a breaking change for Rspack users.

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Jan 27, 2025
@netlify Netlify
Copy link

netlify bot commented Jan 27, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 701e724
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67a33d454e488600081bfa40

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 27, 2025 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2025-01-27 b40fb8c) Current Change
10000_big_production-mode_disable-minimize + exec 37.6 s ± 146 ms 38.9 s ± 985 ms +3.54 %
10000_development-mode + exec 1.82 s ± 31 ms 1.82 s ± 13 ms -0.07 %
10000_development-mode_hmr + exec 684 ms ± 4.7 ms 684 ms ± 7.1 ms +0.02 %
10000_production-mode + exec 2.32 s ± 43 ms 2.31 s ± 71 ms -0.71 %
10000_production-mode_persistent-cold + exec 2.51 s ± 138 ms 2.45 s ± 90 ms -2.36 %
10000_production-mode_persistent-hot + exec 1.65 s ± 23 ms 1.66 s ± 51 ms +0.25 %
arco-pro_development-mode + exec 1.75 s ± 117 ms 1.75 s ± 89 ms -0.33 %
arco-pro_development-mode_hmr + exec 387 ms ± 3.3 ms 388 ms ± 2.4 ms +0.20 %
arco-pro_production-mode + exec 3.7 s ± 273 ms 3.75 s ± 225 ms +1.29 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.73 s ± 160 ms 3.74 s ± 164 ms +0.35 %
arco-pro_production-mode_persistent-cold + exec 3.87 s ± 219 ms 3.89 s ± 124 ms +0.62 %
arco-pro_production-mode_persistent-hot + exec 2.38 s ± 57 ms 2.5 s ± 122 ms +4.94 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.65 s ± 182 ms 3.7 s ± 215 ms +1.18 %
large-dyn-imports_development-mode + exec 2.07 s ± 17 ms 2.09 s ± 83 ms +0.97 %
large-dyn-imports_production-mode + exec 2.13 s ± 61 ms 2.14 s ± 27 ms +0.30 %
threejs_development-mode_10x + exec 1.52 s ± 48 ms 1.53 s ± 7 ms +0.60 %
threejs_development-mode_10x_hmr + exec 784 ms ± 33 ms 794 ms ± 15 ms +1.33 %
threejs_production-mode_10x + exec 5.35 s ± 272 ms 5.28 s ± 69 ms -1.31 %
threejs_production-mode_10x_persistent-cold + exec 5.39 s ± 346 ms 5.36 s ± 181 ms -0.50 %
threejs_production-mode_10x_persistent-hot + exec 4.56 s ± 69 ms 4.64 s ± 391 ms +1.60 %
10000_big_production-mode_disable-minimize + rss memory 8703 MiB ± 57.3 MiB 8725 MiB ± 87.6 MiB +0.26 %
10000_development-mode + rss memory 654 MiB ± 14.9 MiB 658 MiB ± 16.3 MiB +0.48 %
10000_development-mode_hmr + rss memory 1274 MiB ± 268 MiB 1332 MiB ± 177 MiB +4.49 %
10000_production-mode + rss memory 632 MiB ± 19.8 MiB 644 MiB ± 27.6 MiB +1.90 %
10000_production-mode_persistent-cold + rss memory 755 MiB ± 30.3 MiB 748 MiB ± 43.4 MiB -0.97 %
10000_production-mode_persistent-hot + rss memory 731 MiB ± 26.8 MiB 732 MiB ± 12.2 MiB +0.10 %
arco-pro_development-mode + rss memory 566 MiB ± 30.9 MiB 569 MiB ± 23 MiB +0.55 %
arco-pro_development-mode_hmr + rss memory 661 MiB ± 90.8 MiB 661 MiB ± 60.7 MiB -0.02 %
arco-pro_production-mode + rss memory 723 MiB ± 40.1 MiB 715 MiB ± 25 MiB -1.10 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 733 MiB ± 34.4 MiB 739 MiB ± 16.4 MiB +0.81 %
arco-pro_production-mode_persistent-cold + rss memory 850 MiB ± 60 MiB 852 MiB ± 25.7 MiB +0.33 %
arco-pro_production-mode_persistent-hot + rss memory 706 MiB ± 27 MiB 717 MiB ± 28 MiB +1.47 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 731 MiB ± 32.7 MiB 714 MiB ± 15.7 MiB -2.32 %
large-dyn-imports_development-mode + rss memory 651 MiB ± 3.05 MiB 648 MiB ± 5.89 MiB -0.49 %
large-dyn-imports_production-mode + rss memory 532 MiB ± 5.03 MiB 531 MiB ± 11.7 MiB -0.15 %
threejs_development-mode_10x + rss memory 550 MiB ± 4.01 MiB 548 MiB ± 27.2 MiB -0.35 %
threejs_development-mode_10x_hmr + rss memory 1159 MiB ± 138 MiB 1156 MiB ± 132 MiB -0.20 %
threejs_production-mode_10x + rss memory 837 MiB ± 23.5 MiB 842 MiB ± 46.7 MiB +0.59 %
threejs_production-mode_10x_persistent-cold + rss memory 980 MiB ± 33.3 MiB 937 MiB ± 28.4 MiB -4.34 %
threejs_production-mode_10x_persistent-hot + rss memory 883 MiB ± 55 MiB 880 MiB ± 25.1 MiB -0.39 %

@kdy1
Copy link
Contributor

kdy1 commented Jan 27, 2025

SWC changelog: swc-project/swc@[email protected][email protected]

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 27, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #9133 will not alter performance

Comparing bump_swc_v11 (701e724) with main (431a194)

Summary

✅ 6 untouched benchmarks

@chenjiahan chenjiahan changed the title perf(deps): update swc_core to v11.0.0 perf(deps): update swc_core to v11.0.1 Jan 27, 2025
@chenjiahan chenjiahan changed the title perf(deps): update swc_core to v11.0.1 perf(deps): update swc_core to v13 Feb 5, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025 •
edited
Loading

📝 Benchmark detail: Open

Name Base (2025-02-05 22d3a1c) Current Change
10000_big_production-mode_disable-minimize + exec 37.7 s ± 466 ms 38.4 s ± 1.08 s +1.98 %
10000_development-mode + exec 1.83 s ± 18 ms 1.81 s ± 20 ms -1.20 %
10000_development-mode_hmr + exec 684 ms ± 9.3 ms 683 ms ± 9.7 ms -0.14 %
10000_production-mode + exec 2.36 s ± 99 ms 2.26 s ± 82 ms -4.64 %
10000_production-mode_persistent-cold + exec 2.47 s ± 100 ms 2.41 s ± 102 ms -2.43 %
10000_production-mode_persistent-hot + exec 1.7 s ± 198 ms 1.65 s ± 39 ms -2.57 %
arco-pro_development-mode + exec 1.75 s ± 146 ms 1.79 s ± 117 ms +2.03 %
arco-pro_development-mode_hmr + exec 388 ms ± 3.3 ms 387 ms ± 3.4 ms -0.20 %
arco-pro_production-mode + exec 3.65 s ± 165 ms 3.62 s ± 158 ms -0.92 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec 3.8 s ± 298 ms 3.64 s ± 125 ms -4.20 %
arco-pro_production-mode_persistent-cold + exec 3.8 s ± 161 ms 3.76 s ± 170 ms -0.99 %
arco-pro_production-mode_persistent-hot + exec 2.4 s ± 62 ms 2.4 s ± 222 ms -0.31 %
arco-pro_production-mode_traverse-chunk-modules + exec 3.72 s ± 93 ms 3.68 s ± 54 ms -0.90 %
large-dyn-imports_development-mode + exec 2.07 s ± 38 ms 2.05 s ± 49 ms -1.32 %
large-dyn-imports_production-mode + exec 2.14 s ± 40 ms 2.11 s ± 64 ms -0.98 %
threejs_development-mode_10x + exec 1.52 s ± 11 ms 1.52 s ± 40 ms +0.05 %
threejs_development-mode_10x_hmr + exec 773 ms ± 12 ms 792 ms ± 16 ms +2.42 %
threejs_production-mode_10x + exec 5.3 s ± 64 ms 5.15 s ± 74 ms -2.92 %
threejs_production-mode_10x_persistent-cold + exec 5.34 s ± 47 ms 5.26 s ± 296 ms -1.54 %
threejs_production-mode_10x_persistent-hot + exec 4.57 s ± 32 ms 4.52 s ± 342 ms -0.94 %
10000_big_production-mode_disable-minimize + rss memory 8699 MiB ± 60.7 MiB 8740 MiB ± 113 MiB +0.46 %
10000_development-mode + rss memory 656 MiB ± 19 MiB 658 MiB ± 20.4 MiB +0.32 %
10000_development-mode_hmr + rss memory 1242 MiB ± 256 MiB 1328 MiB ± 116 MiB +6.93 %
10000_production-mode + rss memory 630 MiB ± 13.4 MiB 650 MiB ± 14 MiB +3.11 %
10000_production-mode_persistent-cold + rss memory 741 MiB ± 13.5 MiB 753 MiB ± 18 MiB +1.65 %
10000_production-mode_persistent-hot + rss memory 724 MiB ± 7.24 MiB 751 MiB ± 30.3 MiB +3.80 %
arco-pro_development-mode + rss memory 564 MiB ± 12 MiB 586 MiB ± 24.8 MiB +3.82 %
arco-pro_development-mode_hmr + rss memory 650 MiB ± 45.1 MiB 662 MiB ± 103 MiB +1.89 %
arco-pro_production-mode + rss memory 708 MiB ± 38 MiB 724 MiB ± 33.7 MiB +2.38 %
arco-pro_production-mode_generate-package-json-webpack-plugin + rss memory 735 MiB ± 19.8 MiB 740 MiB ± 13 MiB +0.67 %
arco-pro_production-mode_persistent-cold + rss memory 849 MiB ± 54 MiB 851 MiB ± 24.9 MiB +0.14 %
arco-pro_production-mode_persistent-hot + rss memory 702 MiB ± 25 MiB 739 MiB ± 28 MiB +5.29 %
arco-pro_production-mode_traverse-chunk-modules + rss memory 728 MiB ± 31.9 MiB 725 MiB ± 14.6 MiB -0.46 %
large-dyn-imports_development-mode + rss memory 644 MiB ± 13.5 MiB 659 MiB ± 10.5 MiB +2.37 %
large-dyn-imports_production-mode + rss memory 525 MiB ± 3.46 MiB 546 MiB ± 7.35 MiB +4.07 %
threejs_development-mode_10x + rss memory 547 MiB ± 24.7 MiB 552 MiB ± 9.97 MiB +1.00 %
threejs_development-mode_10x_hmr + rss memory 1092 MiB ± 138 MiB 1111 MiB ± 98.2 MiB +1.69 %
threejs_production-mode_10x + rss memory 830 MiB ± 48.8 MiB 845 MiB ± 25.2 MiB +1.77 %
threejs_production-mode_10x_persistent-cold + rss memory 950 MiB ± 54.6 MiB 969 MiB ± 42.7 MiB +2.00 %
threejs_production-mode_10x_persistent-hot + rss memory 870 MiB ± 28.2 MiB 880 MiB ± 62 MiB +1.25 %

@chenjiahan chenjiahan requested a review from JSerFeng February 5, 2025 11:19
@chenjiahan chenjiahan enabled auto-merge (squash) February 5, 2025 13:17
@chenjiahan chenjiahan merged commit 8e7545f into main Feb 6, 2025
32 checks passed
@chenjiahan chenjiahan deleted the bump_swc_v11 branch February 6, 2025 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiveMe-A-Name GiveMe-A-Name GiveMe-A-Name approved these changes

@JSerFeng JSerFeng Awaiting requested review from JSerFeng

Assignees
No one assigned
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chenjiahan @kdy1 @GiveMe-A-Name @hardfist