-
-
Notifications
You must be signed in to change notification settings - Fork 743
fix: commonjs static library mode #9390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspack canceled.Built without sensitive environment variables
|
CodSpeed Performance ReportMerging #9390 will not alter performanceComparing 🎉 Hooray!
|
|
@ahabhgk Could you help review it? Thanks. |
fi3ework
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test case for commonjs-static is supposed to be uncommented here.
rspack/tests/webpack-test/configCases/library/1-use-library/webpack.config.js
Lines 317 to 334 in 80d8625
| // TODO: amd esm import exports presence check | |
| // { | |
| // resolve: { | |
| // alias: { | |
| // library: path.resolve( | |
| // testPath, | |
| // "../0-create-library/commonjs-static-external.js" | |
| // ), | |
| // external: path.resolve(__dirname, "node_modules/external.js") | |
| // } | |
| // }, | |
| // plugins: [ | |
| // new webpack.DefinePlugin({ | |
| // NAME: JSON.stringify("commonjs-static with external"), | |
| // TEST_EXTERNAL: true | |
| // }) | |
| // ] | |
| // }, |
Ok. I will uncomment it. |
931c837 to
22a212a
Compare
|
Done. |
packages/rspack-test-tools/tests/configCases/library/cjs-static/rspack.config.js
Show resolved
Hide resolved
ahabhgk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Summary
Fixes web-infra-dev/rslib#714 (comment)
Checklist