fix: commonjs static library mode

[hai-x]

Summary

Fixes web-infra-dev/rslib#714 (comment)

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).

[netlify]

✅ Deploy Preview for rspack ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	a52bc66
🔍 Latest deploy log	https://app.netlify.com/sites/rspack/deploys/67bc66c8a636460008c1e339
😎 Deploy Preview	https://deploy-preview-9390--rspack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[codspeed-hq]

CodSpeed Performance Report

Merging #9390 will not alter performance

_{Comparing hai-x:fix-cjs-statis (a52bc66) with main (cf4d882)}

Summary

✅ 7 untouched benchmarks

[hai-x]

@ahabhgk Could you help review it? Thanks.

[ahabhgk]

Let's move this test to packages/rspack-test-tools/tests/configCases

[fi3ework]

FWIW, webpack/webpack#19242 is trying to add some test into webpack. We could wait for a while to let it merged into webpack first. Or we could move it to rspack test if there's no response for a while.

[hai-x]

I think both are fine, what do you think?

[fi3ework]

Let's see if it's merged tomorrow.

[fi3ework]

This test case for commonjs-static is supposed to be uncommented here.

rspack/tests/webpack-test/configCases/library/1-use-library/webpack.config.js

Lines 317 to 334 in 80d8625

	// TODO: amd esm import exports presence check
	// {
	// resolve: {
	// alias: {
	// library: path.resolve(
	// testPath,
	// "../0-create-library/commonjs-static-external.js"
	// ),
	// external: path.resolve(__dirname, "node_modules/external.js")
	// }
	// },
	// plugins: [
	// new webpack.DefinePlugin({
	// NAME: JSON.stringify("commonjs-static with external"),
	// TEST_EXTERNAL: true
	// })
	// ]
	// },

[hai-x]

This test case for commonjs-static is supposed to be uncommented here.

rspack/tests/webpack-test/configCases/library/1-use-library/webpack.config.js

Lines 317 to 334 in 80d8625

	// TODO: amd esm import exports presence check
	// {
	// resolve: {
	// alias: {
	// library: path.resolve(
	// testPath,
	// "../0-create-library/commonjs-static-external.js"
	// ),
	// external: path.resolve(__dirname, "node_modules/external.js")
	// }
	// },
	// plugins: [
	// new webpack.DefinePlugin({
	// NAME: JSON.stringify("commonjs-static with external"),
	// TEST_EXTERNAL: true
	// })
	// ]
	// },

Ok. I will uncomment it.