Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(codeowners): removing deprecated package #9395

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

zackarychapple
Copy link
Contributor

The rspack-dev-middleware package was deprecated, this reference was missed.

Summary

Was helping someone debug an issue and was looking for this package. Was not able to find it in the codebase even though it looked like it was being published still. After verifying on NPM the package is deprecated.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

The rspack-dev-middleware package was deprecated, this reference was missed.
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 7bcf718
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b63b1021cfb7000822e6b7
😎 Deploy Preview https://deploy-preview-9395--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codspeed-hq bot commented Feb 19, 2025

CodSpeed Performance Report

Merging #9395 will not alter performance

Comparing zackarychapple:patch-1 (7bcf718) with main (39f13d9)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 7 untouched benchmarks

Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@chenjiahan chenjiahan merged commit 2101c1b into web-infra-dev:main Feb 19, 2025
31 checks passed
@zackarychapple zackarychapple deleted the patch-1 branch February 20, 2025 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants