Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: replace content hashes and full hashes to placeholders in css extract plugin cases #9398

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

LingyuCoder
Copy link
Contributor

Summary

don't want to flush hashes in plugin tests anymore

This pull request includes multiple changes to the tests/plugin-test/css-extract/TestCases.test.js file and several other test files to improve the handling and comparison of hashes in test cases. The most important changes include the addition of functions to normalize paths and retrieve hashes, modifications to the compareDirectory function to handle hashes, and updates to expected test output files to use placeholders for hashes.

Improvements to hash handling in tests:

Updates to expected test output files:

Changes to hash function and digest length:

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit f38c5cf
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b6a548d0f1d300082d82c5

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Feb 20, 2025
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #9398 will not alter performance

Comparing test/css-extract-hashes (f38c5cf) with main (2101c1b)

Summary

✅ 7 untouched benchmarks

@LingyuCoder LingyuCoder merged commit a647744 into main Feb 20, 2025
31 checks passed
@LingyuCoder LingyuCoder deleted the test/css-extract-hashes branch February 20, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants