Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Set optimization level in per-crate basis #9400

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

kdy1
Copy link

@kdy1 kdy1 commented Feb 20, 2025

Summary

This PR reduces the binary size by manually selecting optimization levels for crates.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for rspack canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit efaf81b
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b7dd9c0ba1ca00084e0e18

@kdy1 kdy1 marked this pull request as ready for review February 20, 2025 05:23
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #9400 will not alter performance

Comparing kdy1:size (efaf81b) with main (18420bb)

Summary

✅ 7 untouched benchmarks

@kdy1 kdy1 requested a review from stormslowly February 21, 2025 01:57
@stormslowly
Copy link
Contributor

stormslowly commented Feb 21, 2025

@kdy1
i compare the main branch released .node and current branch released .node

the result is not as expect in my opinion for rspack.linux.*.node

file main branch diff
rspack.darwin-arm64.node 48679024 47787712 -1.83%
rspack.darwin-x64.node 55696144 54364968 -2.39%
rspack.linux-arm64-gnu.node 51590440 61351416 18.92%
rspack.linux-arm64-musl.node 60625992 71944088 18.67%
rspack.linux-x64-gnu.node 60323456 66726456 10.61%
rspack.linux-x64-musl.node 71693760 79292888 10.60%
rspack.win32-arm64-msvc.node 37353472 36690944 -1.77%
rspack.win32-ia32-msvc.node 38904832 37882880 -2.63%
rspack.win32-x64-msvc.node 53959168 52584448 -2.55%

have a look @hardfist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants