Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run codspeed build in parallel #9401

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Conversation

LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Feb 20, 2025

Summary

  • Start building codspeed in parallel
  • Use wait-on-check-action to make sure the binary of build task is ready before running codspeed task

image


This pull request includes several updates to the jobs section in the .github/workflows/reusable-build.yml file. The key changes involve modifying the conditions and steps for the bench job, specifically around the installation of tools and the build process.

Updates to the jobs section:

  • Modification of job dependencies and conditions:

    • Changed the runs-on condition for the bench job to use the inputs.runner instead of the output from the build job.
  • Addition of new steps for the bench job:

    • Added steps to install the Rust toolchain, install the cargo-codspeed binary, build the benchmark, and wait for the build job to complete.
  • Removal of redundant steps:

    • Removed previously existing steps for installing the Rust toolchain, installing the cargo-codspeed binary, and building the benchmark, as these have been restructured and added earlier in the workflow.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Feb 20, 2025
Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit b85db78
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b7fc100845ea0008e5d952

@LingyuCoder LingyuCoder force-pushed the ci/build-codspeed-artifact branch from 1b7fdd6 to 04979a9 Compare February 20, 2025 10:48
@LingyuCoder LingyuCoder changed the title ci: try to upload codspeed artifact ci: try to improve performance of codspeed Feb 20, 2025
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #9401 will not alter performance

Comparing ci/build-codspeed-artifact (b85db78) with main (80eb6d2)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 7 untouched benchmarks

@LingyuCoder LingyuCoder force-pushed the ci/build-codspeed-artifact branch 2 times, most recently from 78ad19d to 4dd0cae Compare February 20, 2025 17:10
@LingyuCoder LingyuCoder force-pushed the ci/build-codspeed-artifact branch from 7b3cc40 to b85db78 Compare February 21, 2025 04:07
@LingyuCoder LingyuCoder changed the title ci: try to improve performance of codspeed ci: run codspeed build parallel Feb 21, 2025
@LingyuCoder LingyuCoder changed the title ci: run codspeed build parallel ci: run codspeed build parallelly Feb 21, 2025
@LingyuCoder LingyuCoder changed the title ci: run codspeed build parallelly ci: run codspeed build in parallel Feb 21, 2025
@LingyuCoder LingyuCoder marked this pull request as ready for review February 21, 2025 06:08
@LingyuCoder LingyuCoder merged commit fab381d into main Feb 21, 2025
41 checks passed
@LingyuCoder LingyuCoder deleted the ci/build-codspeed-artifact branch February 21, 2025 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants