Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sort order incorrect #9404

Merged
merged 1 commit into from
Feb 20, 2025
Merged

fix: sort order incorrect #9404

merged 1 commit into from
Feb 20, 2025

Conversation

JSerFeng
Copy link
Contributor

@JSerFeng JSerFeng commented Feb 20, 2025

Summary

During sort chunk groups, should fallback to ukey only when index is equal or missing

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 27d0d1c
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b6c7d7cce76e000809abe2

@JSerFeng JSerFeng marked this pull request as ready for review February 20, 2025 06:16
@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 20, 2025
@JSerFeng JSerFeng enabled auto-merge (squash) February 20, 2025 06:27
@JSerFeng JSerFeng merged commit 6aac9c2 into main Feb 20, 2025
31 checks passed
@JSerFeng JSerFeng deleted the fix/typo-order branch February 20, 2025 06:55
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #9404 will not alter performance

Comparing fix/typo-order (27d0d1c) with main (8b1ebe5)

Summary

✅ 7 untouched benchmarks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants