Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: render chunk runtime template with dojang #9407

Merged
merged 4 commits into from
Feb 20, 2025

Conversation

GiveMe-A-Name
Copy link
Member

@GiveMe-A-Name GiveMe-A-Name commented Feb 20, 2025

Summary

Use dojang to render runtime modules, related to #5316

More detail summary see: #9079

  • render chunk_prefetch_preload_function template with dojang.
  • render chunk_prefetch_trigger template with dojang.
  • render chunk_prefetch_startup template with dojang.
  • render chunk_preload_trigger template with dojang.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@GiveMe-A-Name GiveMe-A-Name marked this pull request as draft February 20, 2025 07:40
Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit bedc315
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b6ef7db0b5620008f5250d

@github-actions github-actions bot added release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack. labels Feb 20, 2025
Copy link

codspeed-hq bot commented Feb 20, 2025

CodSpeed Performance Report

Merging #9407 will not alter performance

Comparing feat/chunk-runtime-with-dojang (bedc315) with main (b46f13c)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 7 untouched benchmarks

@GiveMe-A-Name GiveMe-A-Name marked this pull request as ready for review February 20, 2025 09:47
@GiveMe-A-Name GiveMe-A-Name merged commit 421ef60 into main Feb 20, 2025
29 checks passed
@GiveMe-A-Name GiveMe-A-Name deleted the feat/chunk-runtime-with-dojang branch February 20, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: feature release: feature related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants