Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move modern module library finish_modules to finish_make #9426

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

ahabhgk
Copy link
Contributor

@ahabhgk ahabhgk commented Feb 21, 2025

Summary

finish_modules means the module graph (modules, connections, dependencies) are frozen and start to optimize (provided exports, infer async, etc.) based on the module graph, so any kind of change that affect these should be done before the finish_modules.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 6ba4488
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b8062b0845ea0008e4cef5

@ahabhgk
Copy link
Contributor Author

ahabhgk commented Feb 21, 2025

!eco-ci

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Feb 21, 2025
Copy link
Contributor

⏳ Triggered ecosystem ci: Open

@ahabhgk ahabhgk enabled auto-merge (squash) February 21, 2025 05:41
@ahabhgk ahabhgk requested a review from fi3ework February 21, 2025 05:41
Copy link

codspeed-hq bot commented Feb 21, 2025

CodSpeed Performance Report

Merging #9426 will not alter performance

Comparing chore-mv-modern-lib-finish-make (6ba4488) with main (f530ed4)

🎉 Hooray! codspeed-rust just leveled up to 2.7.2!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 7 untouched benchmarks

@ahabhgk
Copy link
Contributor Author

ahabhgk commented Feb 21, 2025

Don't know why rsbuild hang in eco-ci, but it passes in my local

@ahabhgk ahabhgk merged commit b69ccff into main Feb 21, 2025
45 of 47 checks passed
@ahabhgk ahabhgk deleted the chore-mv-modern-lib-finish-make branch February 21, 2025 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants