Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: only install binding dependencies when building binary #9429

Merged
merged 9 commits into from
Feb 21, 2025

Conversation

LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Feb 21, 2025

Summary

There is no need to install the whole pnpm workspace dependencies when building binary

This pull request includes updates to the GitHub Actions workflows and custom actions to add more control over dependency installation and caching. The changes introduce a new input parameter to conditionally run the installation steps and update the workflows to use this new parameter.

Key changes:

Updates to .github/actions/pnpm-cache/action.yml:

  • Added run-install input parameter to control whether the installation steps should be executed.
  • Modified the steps to conditionally run based on the run-install input parameter. [1] [2] [3] [4]

Updates to .github/workflows/ci.yml:

  • Added full-install input parameter to several jobs to control whether the full installation should be performed. [1] [2] [3]
  • Added a step to use the updated pnpm-cache action with the new run-install parameter.

Updates to .github/workflows/reusable-build.yml:

  • Added full-install input parameter to control the installation process.
  • Updated the Pnpm Cache step to use the run-install parameter.
  • Added a conditional step to install binding node dependencies if full-install is not set to true.
  • Minor formatting changes for better readability. [1] [2]

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Feb 21, 2025
Copy link

netlify bot commented Feb 21, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit d6e665a
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/67b84814f27fe700088f649c

Copy link

codspeed-hq bot commented Feb 21, 2025

CodSpeed Performance Report

Merging #9429 will not alter performance

Comparing ci/improve-build-pnpm-install (d6e665a) with main (7119e6a)

🎉 Hooray! codspeed-node just leveled up to 4.0.0!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 7 untouched benchmarks

@LingyuCoder LingyuCoder force-pushed the ci/improve-build-pnpm-install branch from 0b3b05a to d6e665a Compare February 21, 2025 09:32
@LingyuCoder LingyuCoder marked this pull request as ready for review February 21, 2025 10:11
@LingyuCoder LingyuCoder enabled auto-merge (squash) February 21, 2025 10:35
@LingyuCoder LingyuCoder merged commit 4bbe65a into main Feb 21, 2025
32 checks passed
@LingyuCoder LingyuCoder deleted the ci/improve-build-pnpm-install branch February 21, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants